CODEWITHSUNDEEP
c#linqlinq-to-entities
Willem
Willem

Reputation: 9476

How to improve the LINQ query?

This is what i got:

int? productID = (ClientProduct != null ? (int?)ClientProduct.ProductID : null);

result = (from po in ((Chase_Media_Pro_Entity_Model)this.NavigationItem.ObjectContext).raPurchaseOrder_List
                  where po.ClientID == Client.CustomerID
                        && ((object.Equals(po.ClientProductID, productID)) || (po.ClientProductID == (productID ?? po.ClientProductID)))
                        && (po.Is_Active == (isActive ?? po.Is_Active))
                        && (po.IsApproved == (isApproved ?? po.IsApproved))
                  orderby po.Is_Active descending, po.IsApproved ascending
                  select po);

Is there a way to improve this line:

&& ((object.Equals(po.ClientProductID, productID)) || (po.ClientProductID == (productID ?? po.ClientProductID)))

This was the only way i could get the right results.

Upvotes: 0

Views: 110

Answers (2)

manji
manji

Reputation: 47978

&& (!productID.HasValue || (productID == po.ClientProductID))

Upvotes: 3

BonyT
BonyT

Reputation: 10940

How about

&& ((productID.HasValue && po.ClientProductID.HasValue) ? po.ClientProductID.Value = productID.Value : true)

Upvotes: 1

Related Questions