CODEWITHSUNDEEP
phpif-statementconditional-statements
Daric
Daric

Reputation: 16769

How better this can be written? PHP code

I am trying to generate final string to show users based on some conditions.

$flag=0;
$var='Please ';
if($user->is_details_updated == 'N' && $user->needs_to_update_details == "Y")
{
    $var='update your profile details';
    $flag=1;
}
if ($flag ==1)
{
    $var=' and ';
}
if($user->is_pass_changed == 'N' && $user->needs_to_update_password == "Y")
{   
    $var.='change password';
}

So, If all three if return true then final $var looks like this:

Please update your profile details and change password

How this can be written better?

Upvotes: 2

Views: 115

Answers (3)

kskaradzinski
kskaradzinski

Reputation: 5084

You can add messages to array and then join them with and

$var = arrray()
if($user->is_details_updated == 'N' && $user->needs_to_update_details == "Y")
{
    $var[] ='update your profile details';

}

if($user->is_pass_changed == 'N' && $user->needs_to_update_password == "Y")
{   
    $var[]='change password';
}

echo join(" and ", $var);

Upvotes: 6

Dickie
Dickie

Reputation: 597

Another suggestion would be (if possible) to refactor the $user->is_details_updated, $user->needs_to_update_details, $user->is_pass_changed, $user->needs_to_update_password properties to return boolean true/false values. This might save some debugging headaches later on.

Upvotes: 0

Matt
Matt

Reputation: 75327

How about:

$sayings = array();

if($user->is_details_updated == 'N' && $user->needs_to_update_details == "Y") {
    $sayings[] = 'update your profile details';
}

if($user->is_pass_changed == 'N' && $user->needs_to_update_password == "Y") {   
    $sayings[] = 'change password';
}

$var = 'Please ' . implode(' and ', $sayings);

Upvotes: 3

Related Questions