CODEWITHSUNDEEP
androidandroid-3.0-honeycombandroid-fragmentsfragmentillegalstateexception
Axel M. Garcia
Axel M. Garcia

Reputation: 5146

Fragment already added IllegalStateException

I use this method on my container Activity to show a BFrag

public void showBFrag()
{
    // Start a new FragmentTransaction
    FragmentTransaction fragmentTransaction = mFragmentMgr.beginTransaction();

    if(mBFrag.isAdded())
    {
        Log.d(LOG_TAG, "Show() BFrag");
        fragmentTransaction.show(mBFrag);   
    }
    else
    {
        Log.d(LOG_TAG, "Replacing AFrag -> BFrag");
        fragmentTransaction.replace(R.id.operation_fragments_frame, mBFrag);
    }

    // Keep the transaction in the back stack so it will be reversed when backbutton is pressed
    fragmentTransaction.addToBackStack(null);

    // Commit transaction
    fragmentTransaction.commit();        
}

I call it from my container Activity; for the first time:

Then I press the back button:

Then I go forward again by calling showBFrag() from the same Activity:

So:

  1. Why is the isAdded() method not returning TRUE if I'm getting a Fragment already added IllegalStateException??
  2. Does popBackStack operation completely remove previously added fragments?
  3. What behaviour am I misunderstanding?

EDIT: Here is the complete info of the exception.

06-07 12:08:32.730: ERROR/AndroidRuntime(8576): java.lang.IllegalStateException: Fragment already added: BFrag{40b28158 id=0x7f0c0085}
06-07 12:08:32.730: ERROR/AndroidRuntime(8576):     at android.app.BackStackRecord.doAddOp(BackStackRecord.java:322)
06-07 12:08:32.730: ERROR/AndroidRuntime(8576):     at android.app.BackStackRecord.replace(BackStackRecord.java:360)
06-07 12:08:32.730: ERROR/AndroidRuntime(8576):     at android.app.BackStackRecord.replace(BackStackRecord.java:352)
06-07 12:08:32.730: ERROR/AndroidRuntime(8576):     at myPackageName.containerActivity.showBFrag() // This line: "fragmentTransaction.replace(R.id.operation_fragments_frame, mBFrag);"

Upvotes: 56

Views: 95735

Answers (11)

litchi
litchi

Reputation: 1

use list keep fragment instance, and judge this:

        if (!mFragmentTags.contains(fragTag + "")) {
                transaction.add(R.id.tab_main_container, mCurrentFragment, fragTag + "");
}

Upvotes: 0

Axel M. Garcia
Axel M. Garcia

Reputation: 5146

In the end my workaround was to execute remove() of the previous fragment and add() the new one. Although that's what replace() method was meant to do.

But I am still guessing why replace() method didn't work properly in this case. It is really weird and I want to discard that it is because I am misunderstanding something or doing something wrong.

Upvotes: 44

Pradeep Kumar Kushwaha
Pradeep Kumar Kushwaha

Reputation: 2239

Removing setOffscreenPageLimit from Viewpager solved my issue. Thanks.

Upvotes: 1

Nartus Team
Nartus Team

Reputation: 170

I used this:

if (getFragmentManager().findFragmentByTag(newFragment.getClass().getName()) != null) {
   transaction.remove(newFragment);
 }

and added fragment with

MyFragment frag = new MyFragment(); 
transaction.add(R.id.container, frag, MyFragment.class.getName())

MyFragment.class.getName() stands for tag

Upvotes: 2

Saleh Sheper
Saleh Sheper

Reputation: 21

try this after fragmentTransection.replace()

fragmentTransection.addToBackStack(null);
fragmentTransection.commitAllowingStateLoss();

Upvotes: 1

kylarsturn
kylarsturn

Reputation: 125

Solved it by looping through my fragments and checking if isAdded() is true, then removing that fragment. More details here.

Upvotes: 0

Jiju Induchoodan
Jiju Induchoodan

Reputation: 4266

Check whether the frament is already added or not using the method fragment.isAdded() Do replace or add the fragment accordingly

Upvotes: 1

Muhammad Aamir Ali
Muhammad Aamir Ali

Reputation: 21097

This code is working fine for me. try this

((MiActivity)getActivity()).addAccount = new AddAccount();
((MiActivity)getActivity()).addAccount.setArguments(params);
fragmentManager = getActivity().getSupportFragmentManager();
fragmentTransaction = fragmentManager.beginTransaction();
fragmentTransaction.replace(R.id.fragment_container((MiActivity)getActivity()).addAccount);
fragmentTransaction.addToBackStack(null);
fragmentTransaction.commit();

Upvotes: 0

ObviousChild
ObviousChild

Reputation: 119

I tried calling FragmentTransaction.remove() from onTabUnselected() and it worked around this bug.

@Override
public void onTabSelected(Tab tab, FragmentTransaction ft) {
    ft.add(R.id.fragment_container, fragment, null);
}

@Override
public void onTabUnselected(Tab tab, FragmentTransaction ft) {
    ft.remove(fragment);
}

Upvotes: 0

Johan Paul
Johan Paul

Reputation: 2456

Probably not related to this issue directly, but I've also noticed that setting a transition to the FragmentTransaction will cause an IllegalStateException, while not setting a transition will not.

Here's the bug for this issue: http://code.google.com/p/android/issues/detail?id=25598

Upvotes: 8

Nathan Schwermann
Nathan Schwermann

Reputation: 31493

If the state of the activity has already been saved its no longer safe to call commit. You must call commitAllowingStateLoss() instead. Hope this helps!

Edit: ok I've taken a closer look at your issue, problem is you are trying to add a fragment that has already been added. Even if you use replace or remove calls you can't do this. Only work around I have found is to create a new instance of a fragment and add it every time. Once you remove or replace a fragment it is best to drop all of your references to it so the GC can take care of it.

Upvotes: 12

Related Questions