Why does using my custom class cause a memory error?

Question

I get the following memory leak errors which correspond with the parser method below. That is every time I use my custom class's setter (4 times), I get a memory error leak:

Leaked Object   #   Address Size    Responsible Library Responsible Frame
NSCFString  630 < multiple >    20160   Foundation  -[NSCFString copyWithZone:]
NSCFString  625 < multiple >    10000   Foundation  -[NSCFString copyWithZone:]
NSCFString  623 < multiple >    19936   Foundation  -[NSCFString copyWithZone:]
NSCFString  613 < multiple >    23664   Foundation  -[NSCFString copyWithZone:]

my custom class interface:

#import <Foundation/Foundation.h>

@interface FaxRecipient : NSObject {
    NSString * contactID;
    NSString * name;
    NSString * fax;
    NSString * company;
    NSString * phone;
}
@property(nonatomic,copy)NSString *contactID;
@property(nonatomic,copy)NSString *name;
@property(nonatomic,copy)NSString *fax;
@property(nonatomic,copy)NSString *company;
@property(nonatomic,copy)NSString *phone;

@end

implementation:

#import "FaxRecipient.h"

@implementation FaxRecipient
@synthesize contactID, name, fax, company, phone;
@end

I am using it in the following context:

 -(void)parser:(NSXMLParser *)parser
    didStartElement:(NSString *) elementName
     namespaceURI:(NSString *)namespaceURI
    qualifiedName:(NSString *)qName
       attributes:(NSDictionary *)attributeDict
{

    if ([elementName isEqual:@"ContactId"]) {
        faxRecipient =[[FaxRecipient alloc]init];
        remoteRecipientString = [[NSMutableString alloc]init]; 
    }

    else if ([elementName isEqual:@"Name"]) {
        remoteRecipientString = [[NSMutableString alloc]init]; 


    }else if ([elementName isEqual:@"Fax"]) {
        remoteRecipientString = [[NSMutableString alloc]init];
    }

    else if ([elementName isEqual:@"Rec"]) {
        remoteRecipientString = [[NSMutableString alloc]init];
    }

}

-(void) parser:(NSXMLParser *)parser
foundCharacters:(NSString *)string{

    [remoteRecipientString appendString:string];

}


-(void)parser:(NSXMLParser *)parser
didEndElement:(NSString *) elementName
 namespaceURI:(NSString *)namespaceURI
qualifiedName:(NSString *)qName{


    if ([elementName isEqual:@"ContactId"]) {
        faxRecipient.contactID = remoteRecipientString;
        [remoteRecipientString release];
        remoteRecipientString = nil;
    }


    if ([elementName isEqual:@"Name"]) {
        faxRecipient.name = remoteRecipientString;
        [remoteRecipientString release];
        remoteRecipientString = nil;
    }   


    if ([elementName isEqual:@"Fax"]) {
        faxRecipient.fax = remoteRecipientString;
        [remoteRecipientString release];
        remoteRecipientString = nil;

    }

    if ([elementName isEqual:@"Rec"]) {
        faxRecipient.phone = remoteRecipientString;
        [remoteRecipientItems addObject:faxRecipient];//delivery complete as this is end of xml
        [faxRecipient release];
        faxRecipient = nil;
        [remoteRecipientString release];
        remoteRecipientString = nil;

    }


}

Answer 1

You have to implement the dealloc method where you will release the copied strings.

- (void) dealloc
{
    [super dealloc];
    [contactID release];
    [name release];
    [fax release];
    [company release];
    [phone release];
}