CODEWITHSUNDEEP
rustobject-lifetime
Tr3nchHvlk
Tr3nchHvlk

Reputation: 157

How do I fix the lifetime mismatch when returning a mutable reference to the struct's field from a trait method?

This is my attempt to return a mutable reference to the struct's field.

pub trait Objective {
    fn get_children<'a>(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>>;
    fn get_parent(&'_ mut self) -> &'_ mut Box<dyn Objective>;
    fn update(&'_ self) -> ();
}

// #[derive(Objective)]
pub struct Object<'a> {
    children: Vec<&'a mut Box<dyn Objective>>,
    parent: &'a mut Box<dyn Objective>,
}

impl<'a> Objective for Object<'a> {
    fn get_children(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
        return &mut self.children;
    }

    fn get_parent(&'_ mut self) -> &'_ mut Box<dyn Objective> {
        return self.parent;
    }

    fn update(&'_ self) -> () {}
}

There is a problem with the lifetime. Here is the error given by the compiler:

error[E0308]: method not compatible with trait
  --> src/lib.rs:14:5
   |
14 |     fn get_children(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetime mismatch
   |
   = note: expected fn pointer `fn(&'a mut Object<'a>) -> &'a mut std::vec::Vec<&'a mut std::boxed::Box<(dyn Objective + 'static)>>`
              found fn pointer `fn(&'a mut Object<'a>) -> &'a mut std::vec::Vec<&'a mut std::boxed::Box<(dyn Objective + 'static)>>`
note: the lifetime `'a` as defined on the method body at 14:5...
  --> src/lib.rs:14:5
   |
14 |     fn get_children(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...does not necessarily outlive the lifetime `'a` as defined on the impl at 13:6
  --> src/lib.rs:13:6
   |
13 | impl<'a> Objective for Object<'a> {
   |      ^^

error[E0308]: method not compatible with trait
  --> src/lib.rs:14:5
   |
14 |     fn get_children(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lifetime mismatch
   |
   = note: expected fn pointer `fn(&'a mut Object<'a>) -> &'a mut std::vec::Vec<&'a mut std::boxed::Box<(dyn Objective + 'static)>>`
              found fn pointer `fn(&'a mut Object<'a>) -> &'a mut std::vec::Vec<&'a mut std::boxed::Box<(dyn Objective + 'static)>>`
note: the lifetime `'a` as defined on the impl at 13:6...
  --> src/lib.rs:13:6
   |
13 | impl<'a> Objective for Object<'a> {
   |      ^^
note: ...does not necessarily outlive the lifetime `'a` as defined on the method body at 14:5
  --> src/lib.rs:14:5
   |
14 |     fn get_children(&'a mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Here is my earlier attempt at this which where I did not explicitly specify the lifetime:

pub trait Objective {
    fn get_children(&'_ mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>>;
    fn get_parent(&'_ mut self) -> &'_ mut Box<dyn Objective>;
    fn update(&'_ self) -> ();
}

// #[derive(Objective)]
pub struct Object<'a> {
    children: Vec<&'a mut Box<dyn Objective>>,
    parent: &'a mut Box<dyn Objective>,
}

impl Objective for Object<'_> {
    fn get_children(&'_ mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
        return &mut self.children;
    }

    fn get_parent(&'_ mut self) -> &'_ mut Box<dyn Objective> {
        return self.parent;
    }

    fn update(&'_ self) -> () {}
}

And I've gotten a similar error:

error[E0308]: mismatched types
  --> src/lib.rs:15:16
   |
15 |         return &mut self.children;
   |                ^^^^^^^^^^^^^^^^^^ lifetime mismatch
   |
   = note: expected mutable reference `&mut std::vec::Vec<&mut std::boxed::Box<(dyn Objective + 'static)>>`
              found mutable reference `&mut std::vec::Vec<&mut std::boxed::Box<(dyn Objective + 'static)>>`
note: the anonymous lifetime #1 defined on the method body at 14:5...
  --> src/lib.rs:14:5
   |
14 | /     fn get_children(&'_ mut self) -> &'_ mut Vec<&'_ mut Box<dyn Objective>> {
15 | |         return &mut self.children;
16 | |     }
   | |_____^
note: ...does not necessarily outlive the lifetime `'_` as defined on the impl at 13:27
  --> src/lib.rs:13:27
   |
13 | impl Objective for Object<'_> {
   |                           ^^

How do I fix this?

Upvotes: 3

Views: 689

Answers (1)

richerarc
richerarc

Reputation: 250

Specify the lifetime on the trait and it works:

pub trait Objective<'a> {
    fn get_children(&mut self) -> &mut Vec<&'a mut Box<dyn Objective<'a>>>;
    fn get_parent(&mut self) -> &mut Box<dyn Objective<'a>>;
    fn update(&self) -> ();
}

// #[derive(Objective)]
pub struct Object<'a> {
    children: Vec<&'a mut Box<dyn Objective<'a>>>,
    parent: Box<dyn Objective<'a>>,
}

impl<'a> Objective<'a> for Object<'a> {
    fn get_children(&mut self) -> &mut Vec<&'a mut Box<dyn Objective<'a>>> {
        &mut self.children
    }

    fn get_parent(&'_ mut self) -> &mut Box<dyn Objective<'a>> {
        &mut self.parent
    }

    fn update(&'_ self) -> () {}
}

By specifying the lifetime on Objective, we can make sure that implementers will return a Vec of mutable references that satisfies the same lifetime requirements as the one needed by the trait.

Upvotes: 2

Related Questions