CODEWITHSUNDEEP
pythonpython-3.xrandomdiscorddiscord.py
Dan A
Dan A

Reputation: 414

Wrong outputs on on_message while using a random number generator

from discord.ext import commands
import discord
import random

class Ship(commands.Cog):
    def __init__(self, bot):
        self.bot = bot

    
    @commands.Cog.listener()
    async def on_message(self, message):
        if (message.guild.id == 464298877823221761) or (message.guild.id == 548945695034310697) or (message.guild.id == 712143774935154689):
            if message.content.find("!ship") != -1:
                line = message.content
                name = line.split(' ')[1]
                name2 = line.split(' ')[2]
                number = random.randint(0,100)
                if 0 <= number <= 10:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Awful :sob:')
                    number = random.randint(0,100)
                if 11 <= number <= 19:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Bad :cry:')
                    number = random.randint(0,100)
                if 20 <= number <= 29:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Pretty Low :frowning:')
                    number = random.randint(0,100)
                if 30 <= number <= 39:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Not Great :confused:')
                    number = random.randint(0,100)
                if 40 <= number <= 49:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Not Too Bad :confused:')
                    number = random.randint(0,100)
                if 50 <= number <= 59:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Barely :no_mouth:')
                    number = random.randint(0,100)
                if 60 <= number <= 69:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Not Bad :slight_smile:')
                    number = random.randint(0,100)
                if 70 <= number <= 79:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Pretty Good :smiley:')
                    number = random.randint(0,100)
                if 80 <= number <= 89:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Great :smile:')
                    number = random.randint(0,100)
                if 90 <= number <= 99:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** Amazing :heart_eyes:')
                    number = random.randint(0,100)
                elif 100 == number:
                    await message.channel.send(':heartpulse:**MATCHMAKING**:heartpulse:\n:small_red_triangle_down:`' + name +'`'+ '\n:small_red_triangle:`' + name2 + '`' + '\n**' + str(number) + '%** **PERFECT** :heart_exclamation:')
                    number = random.randint(0,100)

def setup(bot):
    bot.add_cog(Ship(bot))

I think that title sums it up, when I turn the bot on and type in !ship followed by 2 names the code spits out 2 messages but the second time I type in the command I get 1 output as intended

please look in the comments of this question for more info about my problem

Upvotes: 0

Views: 70

Answers (1)

Lo&#239;c
Lo&#239;c

Reputation: 11943

Your problem lies in your conditions.

See first condition for example :

if (number >= 0) or (number <= 10):

This will take ANY number. You want number >= 0 AND number <= 10.

By the way you can do it like this:

if 0 <= number <= 10:

Also you shouldn't randomize a new number in each condition.

One last thing, you seem to do it 10 by 10, so you can do something much easier like :

labels = {0: "awful", 1: "bad", 2 : "decent", ...}
number = random.randint(0,100)
label = labels[int(number/10)]
await message.channel.send(
  f"heartpulse:**MATCHMAKING**:heartpulse:\n
    :small_red_triangle_down:`{name}`\n
    :small_red_triangle:`{name2}`\n
    **{number}%** **{label}** :heart_exclamation:")

Upvotes: 2

Related Questions