CODEWITHSUNDEEP
c#winformsapirevit
kennyb6
kennyb6

Reputation: 11

Revit API External Command freezing after WinForms Close() event

I am trying to create an external command for Revit that pops up a windows forms that has a single text box for the user to enter a description. After the user clicks Ok, the form closes but Revit gets stuck in a loading motion. It doesn't freeze, it just is constantly loading something. When I pause debugging, the code only made it to the line form.ShowDialog(). If I take out the showdialog and just run it without the form, it runs fine.

I'll post my relevant code snippets below. The form is in its own .cs, separate from the external command .cs but still under the same namespace.

Form click events code:

private void CancelForm(object sender, EventArgs e)
{
    isReport = false;
    this.DialogResult = DialogResult.Cancel;
    Close();
}

private void SubmitForm(object sender, EventArgs e)
{
    isReport = true;
    reportDesc = descriptionBox.Text;
    this.DialogResult = DialogResult.OK;
    Close();
}

Execute command:

    public Result Execute(ExternalCommandData commandData, ref string message, ElementSet elements)
    {
        //Get application and document objects
        UIApplication uiapp = commandData.Application;
        Document doc = uiapp.ActiveUIDocument.Document;
        ReportForm ticket = new ReportForm();
        ticket.ShowDialog();

The code stops processing after showdialog. From what I could read on it, I thought it might have to do with focus on Revit after the form closing or the form not closing properly but couldn't figure out how to fix it.

Any help would be greatly appreciated!

Upvotes: 0

Views: 626

Answers (2)

kennyb6
kennyb6

Reputation: 11

I ended up remaking the entire addin, made sure I was using Jeremy Tammik's Revit Addin Wizard to initiate it, and it started working. Not exactly sure what fixed it but guessing it was some error in the set up or such.

Upvotes: 1

Jeremy Tammik
Jeremy Tammik

Reputation: 8339

Here is an old sample that creates a minimal Windows form on the fly, displays it as a modal form and closes successfully afterwards: The Schedule API and Access to Schedule Data. Maybe that will help. Maybe the debugger is interfering with the form closing somehow?

Upvotes: 1

Related Questions