CODEWITHSUNDEEP
javascriptif-statement
gerpaick
gerpaick

Reputation: 799

convert nested if statements to more elegant switch?

how can i convert this nested if statement to something more readable and 'elegant'?

if(speed==0){
            othvalue=0;
        }else {
            if(speed>value1864cmn){
                othvalue=value1864cmn;
            }else {
                if(speed>value1746cmn){
                    othvalue=value1746cmn;
                }else {
                    if(speed>value1628cmn){
                        othvalue=value1628cmn;
                    }else {
                        if(speed>value1510cmn){
                            othvalue=value1510cmn;
                        }else {
                            if(speed>value1392cmn){
                                othvalue=value1392cmn;
                            }else {
                                if(speed>value1274cmn){
                                    othvalue=value1274cmn;
                                }else {
                                    if(speed>value1156cmn){
                                        othvalue=value1156cmn;
                                    }else {
                                        if(speed>value1038cmn){
                                            othvalue=value1038cmn;
                                        }else {
                                            if(speed>value920cmn){
                                                othvalue=value920cmn;
                                            }
                                        }
                                    }
                                }
                            }
                        }
                    }
                }
            }
        };

Upvotes: 1

Views: 1423

Answers (5)

c-smile
c-smile

Reputation: 27470

You can use "match" construct:

var othvalue = (speed == 0) ? 0 
             : (speed <= 10) ? 10
             : (speed <= 20) ? 20
             : (speed <= 30) ? 30
             : 40;

Upvotes: 5

kennebec
kennebec

Reputation: 104800

// I don't know about elegant, but stepping through an array is pretty quick.

function setSpeedValue(speed){
    var L= 9, values= [0, 920, 1038, 1156, 1274, 1392, 1510, 1628, 1746, 1864];
    while(values[L]>speed)--L;
    return 'value'+values[L]+'cmn';
}
alert(setSpeedValue(1040))

Upvotes: 1

rid
rid

Reputation: 63542

if (speed == 0) {
    othvalue = 0;
} else {
    var values = [
        value1746cmn, value1628cmn, value1510cmn, value1392cmn, value1274cmn,
        value1156cmn, value1038cmn, value920cmn
    ];
    for (var i in values) {
        if (speed > values[i]) {
            othvalue = values[i];
            break;
        }
    }
}

Upvotes: 1

Igor
Igor

Reputation: 33992

if (speed == 0) {
    othvalue = 0;
} else if (speed > value1864cmn) {
    othvalue = value1864cmn;
} else if (speed > value1746cmn) {
    othvalue = value1746cmn;
} else if (speed > value1628cmn) {
    othvalue = value1628cmn;
} else if (speed > value1510cmn) {
    othvalue = value1510cmn;
} else if (speed > value1392cmn) {
    othvalue = value1392cmn;
} else if (speed > value1274cmn) {
    othvalue = value1274cmn;
} else if (speed > value1156cmn) {
    othvalue = value1156cmn;
} else if (speed > value1038cmn) {
    othvalue = value1038cmn;
} else if (speed > value920cmn) {
    othvalue = value920cmn;
};

Upvotes: 1

Andrew Arnott
Andrew Arnott

Reputation: 81811

You don't need to nest this, nor convert it to a switch statement. Just put the if right next to the else.

For instance:

if(speed==0){
    othvalue=0;
} else if(speed>value1864cmn){
    othvalue=value1864cmn;
} else if {
...

Upvotes: 3

Related Questions