React: Pomodoro Clock: How to convert to `MM:SS`?

Question

The this React Pomodoro clock, in the function countDown there is a function secondsToMins which converts seconds to MM:SS. However, when tMinus reaches 0, secondsToMins does not fire at all. Any help would be greatly appreciated.

index.js

import React from 'react';
import ReactDOM from 'react-dom';
import './style.css';

/*
* A simple React component
*/
const initState = {
  breakLength: 5,
  breakSeconds: undefined,
  sessionLength: 25,
  sessionSeconds: undefined,
  initSessionSeconds: undefined,
  init: 'session',
  timeLeft: undefined,
  started: false,
  intervalFunc: undefined
}

const secondsToMins = (time) => {
  //let converted = Math.floor(time / 60) + ':' + ('0' + Math.floor(time % 60)).slice(-2);
  let converted = ('0' + Math.floor(time / 60)).slice(-2) + ':' + ('0' + Math.floor(time % 60)).slice(-2);

  //console.log('converted')
  //console.log(converted)
  //console.log('#######')

  return converted;
}

class Clock extends React.Component {

  constructor(props) {
    super(props);
    this.state = initState;
    this.breakDecrement = this.breakDecrement.bind(this);
    this.breakIncrement = this.breakIncrement.bind(this);
    this.sessionDecrement = this.sessionDecrement.bind(this);
    this.sessionIncrement = this.sessionIncrement.bind(this);
    this.startStop = this.startStop.bind(this);
    this.reset = this.reset.bind(this);
  }

  componentDidMount() {
    // seconds are used for the countDown()
    // seconds are converted to MM:SS at every t-minus
    let breakSeconds = this.state.breakLength * 60;
    let sessionSeconds = this.state.sessionLength * 60;

    // Initialize everything
    this.setState({ breakSeconds: breakSeconds });
    this.setState({ sessionSeconds: sessionSeconds });
    this.setState({ timeLeft: secondsToMins(sessionSeconds) });
  }

  breakDecrement() {
    // decrements the breakLength and the breakSeconds
    // breakLength is only a number ie. 5 (does not show seconds)
    // breakSeconds is that nunber converted into seconds
    let breakLength = this.state.breakLength - 1;
    if (breakLength > 0 && breakLength < 61){
      this.setState({ breakLength: breakLength });
      let breakSeconds = this.state.breakLength * 60;
      this.setState({ breakSeconds: breakSeconds });
    }
  }

  breakIncrement() {
    // same as decrement except does increment
    let breakLength = this.state.breakLength + 1;
    if (breakLength > 0 && breakLength < 61){
      this.setState({ breakLength: breakLength });
      let breakSeconds = this.state.breakLength * 60;
      this.setState({ breakSeconds: breakSeconds });
    }
  }

  sessionDecrement() {
    // decrements the sessionLength and the sessionSeconds
    // sessionLength is only a number ie. 25 (does not show seconds)
    // sessionSeconds is that nunber converted into seconds
    let sessionLength = this.state.sessionLength - 1;
    if (sessionLength > 0 && sessionLength < 61){
      this.setState(prevState => ({
        sessionLength: prevState.sessionLength-1,
        sessionSeconds: (prevState.sessionLength-1)*60,
        initSessionSeconds: (prevState.sessionLength-1)*60,
        timeLeft:  secondsToMins((prevState.sessionLength-1)*60)})
      );
    }
  }

  sessionIncrement() {
    // same as decrement except does increment
    let sessionLength = this.state.sessionLength + 1;
    if (sessionLength > 0 && sessionLength < 61){
      this.setState(prevState => ({
        sessionLength: prevState.sessionLength+1,
        sessionSeconds: (prevState.sessionLength+1)*60,
        initSessionSeconds: (prevState.sessionLength+1)*60,
        timeLeft:  secondsToMins((prevState.sessionLength+1)*60)})
      );
    }
  }

  startStop(id) {
    // starts the countDown, which runs continuously until the start/stop button
    // is pressed again, which pauses the countdown.
    // the id parameter is used by countDown to play the audio beep
    if(!this.state.started){
      this.countDown(id);
      this.setState({ started: true});
    }
    // pauses the countDown
    if(this.state.started){
      let intervalFunc = this.state.intervalFunc;
      clearInterval(intervalFunc);
      this.setState({ started: false});
    }
  }

  reset() {
    let intervalFunc = this.state.intervalFunc;
    clearInterval(intervalFunc);
    // reset state to default values
    this.setState({ breakLength: 5 });
    this.setState({ sessionLength: 25 });
    this.setState({ init: 'session' });
    this.setState({ timeLeft: '25:00' });
  }

  countDown(id){
    // set the function to a variable and set state to it, so the function
    // can be paused with clearInterval()
    var intervalFunc = setInterval(() => down(this.state.sessionSeconds--), 1000);
    this.setState({intervalFunc: intervalFunc});

    // seconds are converted to MM:SS at every t-minus
    const down = (time) =>
    {
      if(time >= 0){
        // converts seconds to MM:SS at every t-minus
        console.log(this.state.sessionSeconds);
        this.setState({ timeLeft: secondsToMins(time) });
        console.log(this.state.timeLeft);
      }

      // when sessionSeconds reaches 0, start the break
      // by setting sessionSeconds to breakSeconds
      if(time == 0 && this.state.init == 'session'){
        let sound = document.getElementById(id).childNodes[0];
        sound.play();
        this.setState({ init: 'break' });
        this.setState({ sessionSeconds: this.state.breakSeconds});
        this.setState({ timeLeft: secondsToMins(this.state.sessionSeconds)});
      }

      // when breakSeconds reaches 0, start the session
      // by setting sessionSeconds to initSessionSeconds
      if(time == 0 && this.state.init == 'break'){
        let sound = document.getElementById(id).childNodes[0];
        sound.play();
        this.setState({ init: 'session' });
        this.setState({ sessionSeconds: this.state.initSessionSeconds})
        this.setState({ timeLeft: secondsToMins(this.state.sessionSeconds)});
      }
    }
  }


  render() {
    return (
      <div id="clock">
      <h1 id="title">25-5 Clock</h1>

      <div>
      <p id="break-label">Break Length</p>
      <p id="break-length">{this.state.breakLength}</p>
      <button id="break-decrement" onClick={e => this.breakDecrement()}> Decrease </button>
      <button id="break-increment" onClick={e => this.breakIncrement()}> Increase </button>
      </div>

      <div>
      <p id="session-label">Session Length</p>
      <p id="session-length">{this.state.sessionLength}</p>
      <button id="session-decrement" onClick={e => this.sessionDecrement()}> Decrease </button>
      <button id="session-increment" onClick={e => this.sessionIncrement()}> Increase </button>
      </div>

      <hr/>

      <div>
      <p id="timer-label">{this.state.init}</p>
      <p id="time-left">{this.state.timeLeft}</p>
      <button id="start_stop" onClick={e => this.startStop(e.target.id)}><audio id="beep" src='./beep.mp3'></audio> start/stop </button>
      <button id="reset" onClick={e => this.reset()}> reset </button>
      </div>

      </div>
    );
  }
};

/*
* Render the above component into the div#app
*/
ReactDOM.render(<Clock />, document.getElementById("app"));

index.html

<!DOCTYPE html>
<html lang="en" dir="ltr">
<head>
  <meta charset="utf-8">
  <title>25-5 Clock</title>
  <style>
  </style>
</head>
<body>
  <main>
    <div id="app"></app>
    </main>
  </body>
  </html>

Answer 1

The problem is your decrementing this.state.sessionSeconds BEFORE secondsToMins() is called. So at tMinus 0, this.state.sessionSeconds is already -1 instead of the expected 0.

countDown(id) {
    // set the function to a variable and set state to it, so the function
    // can be paused with clearInterval()
    var intervalFunc = setInterval(() => down(this.state.sessionSeconds--), 1000);// -- decrements the variable
}

Quickest fix would be to check on tMinus to determine if secondsToMinutes() should be ran. This is not the proper fix though.

if (tMinus >= 0) {
    // converts seconds to MM:SS at every t-minus
    this.setState({ timeLeft: secondsToMins(tMinus) });
}