CODEWITHSUNDEEP
djangodjango-modelsdjango-formsdjango-viewsdjango-templates
Benjamin Rafatian
Benjamin Rafatian

Reputation: 11

Django form creating new record instead of updating

I'm creating a user update form in my app. but every time when the form is submitted , it creates a new record and if you try submitting again will return Integrity Error(duplicate username that both are null).

ERROR message: django.db.utils.IntegrityError: UNIQUE constraint failed: auth_user.username

forms.py:

class UserChangeForm(forms.ModelForm):

    class Meta:
        model = User
        fields = ['email', 'first_name', 'last_name']

    def __init__(self, username, *args, **kwargs):
        super(UserChangeForm, self).__init__(*args, **kwargs)
        self.username = username

views.py:

def profile(request):

    user = request.user

    if request.method == 'POST':
        user_form = UserChangeForm(user, request.POST)

        if user_form.is_valid():
            user_form.save()
            messages.success(request, f'Your account has been updated!')

            return redirect('users:profile')

    else:
        email = request.user.email
        first_name = request.user.first_name
        last_name = request.user.last_name
        user_form = UserChangeForm(user, initial={
            'email': email,
            'first_name': first_name,
            'last_name': last_name
        })

    context = {
        'user_form': user_form,
    }

    return render(request, 'users/profile.html', context)

Upvotes: 1

Views: 456

Answers (1)

Mahmoud Ahmed
Mahmoud Ahmed

Reputation: 170

you need to pass the user as instance in the if condition and in else too like this

def profile(request):
    if request.method == 'POST':
        user_form = UserChangeForm(request.POST , instance = request.user)

        if user_form.is_valid():
            user_form.save()
            messages.success(request, f'Your account has been updated!')

            return redirect('users:profile')

    else:
        user_form = UserChangeForm(instance=request.user)

    context = {
        'user_form': user_form,
    }
    return render(request, 'users/profile.html', context)

Upvotes: 1

Related Questions