CODEWITHSUNDEEP
javaspringspring-mvcjunitmockito
David Àlvarez Tudela
David Àlvarez Tudela

Reputation: 421

Spring Framework - Mock is not mocking

I have a Spring MvC app. (The Spring Framework is an application framework and inversion of control container for the Java platform) with this test:

    @RunWith(SpringJUnit4ClassRunner.class)
    public class AutorisationServiceTest {
    
        @Autowired
        @InjectMocks
        private IAutorisationService service;
    
        @Mock
        PersonneRepository personneRepository = Mockito.mock(PersonneRepository.class);
    
    
        @Before
        public void setup() {
        }
    
    
        @Test
        public void should_Find_GardeWith2Affectations() throws IOException {
    
            when(personneRepository.getAll(anyString())).thenReturn(DataLoader.mockData());
            service.getAll("rules");
        }
    
    }

    @Service
    public class AutorisationService implements IAutorisationService {
    
        private final PersonneRepository personneRepository;
    
        public AutorisationService(PersonneRepository personneRepository) {
            this.personneRepository = personneRepository;
        }

@Override
    public List<User> getAll(String where) {
        return personneRepository.getAll(where));
    }
    ...
    }

but when I run the test it seems no to mock the repo

Upvotes: 0

Views: 822

Answers (4)

cdalxndr
cdalxndr

Reputation: 1541

This answer is for testng:

MockitoTestExecutionListener initializes mocks, and you need to use @MockBean annotation.

@RunWith(SpringJUnit4ClassRunner.class)
@TestExecutionListeners(MockitoTestExecutionListener.class)
public class AutorisationServiceTest {   
    @MockBean
    PersonneRepository personneRepository;

Also, don't forget to add ResetMocksTestExecutionListener to prevent inter-test persistent mocks (see this issue).

Upvotes: 1

oliver_t
oliver_t

Reputation: 1095

You should decide whether you want to write a Spring test or a Mockito test.

A spring test will load the full context and you can then work with @Autowired and @MockBean:

@RunWith(SpringJUnit4ClassRunner.class)
public class AutorisationServiceTest {
    
  @Autowired
  private IAutorisationService service;
    
  @MockBean
  PersonneRepository personneRepository;

A Mockito test runs much faster, but you will only have the objects you explicitly configured with @InjectMocks or @Mock:

@RunWith(MockitoJUnitRunner.class)
public class AutorisationServiceTest {
  
  @InjectMocks
  private IAutorisationService service;
    
  @Mock
  PersonneRepository personneRepository;

Note that you never have to instanciate the mock with Mockito.mock() when using annotations and specialized runners.

I guess your PersonneRepository is a @Service, @Component or @Repository. So you should use auto-wiring here as well:

@Service
public class AutorisationService implements IAutorisationService {

   @Autowired    
   private PersonneRepository personneRepository;

Upvotes: 1

Heena Tabassum
Heena Tabassum

Reputation: 128

In @Before setup method you need to add MockitoAnnotations.initMocks(this). This will inject your mocked services. I have modified the code below :

@RunWith(SpringJUnit4ClassRunner.class)
    public class AutorisationServiceTest {
    
        @Mock
        PersonneRepository personneRepository;

        @InjectMocks
        private AutorisationService service;
    
        @Before
        public void setup() {
          MockitoAnnotations.initMocks(this);
        }
    
    
        @Test
        public void should_Find_GardeWith2Affectations() throws IOException {
    
            when(personneRepository.getAll(anyString())).thenReturn(DataLoader.mockData());
            service.getAll("rules");
        }
    
    }

    @Service
    public class AutorisationService implements IAutorisationService {
    
        private final PersonneRepository personneRepository;
    
        public AutorisationService(PersonneRepository personneRepository) {
            this.personneRepository = personneRepository;
        }

@Override
    public List<User> getAll(String where) {
        return personneRepository.getAll(where));
    }
    ...
    }

Upvotes: 0

gpopides
gpopides

Reputation: 736

You can't use both @Mock and Mockito.mock. Choose one of them

Upvotes: 0

Related Questions