CODEWITHSUNDEEP
javascript
santiagoterosa
santiagoterosa

Reputation: 17

How to randomise the order of image slider

I have a image slider code which is working good. But I need to randomise the order of the pics so NOT everytime pic1 is shown first, pic2 shown second and than pic3 shown third. I want to randomise the order of the pics so evertytime page is load, pics to have different order. And I need help with that. Here is my code:

 <img class="mySlides" src="pic1.jpg">
 <img class="mySlides" src="pic2.jpg">
 <img class="mySlides" src="pic3.jpg">


<script>
var myIndex = 0;
carousel();

function carousel() {
  var i;
  var x = document.getElementsByClassName("mySlides");
  for (i = 0; i < x.length; i++) {
    x[i].style.display = "none";  
  }
  myIndex++;
  if (myIndex > x.length) {myIndex = 1}    
  x[myIndex-1].style.display = "block";  
  setTimeout(carousel, 2000); // Change image every 2 seconds
}
</script>

Upvotes: 1

Views: 484

Answers (2)

0xdw
0xdw

Reputation: 3842

Change the order of elements in-place may help you.

let index = 0;

function randomise_list() {
  const list = document.querySelector("#slider");
  for (let i = list.children.length; i >= 0; i--) {
    list.appendChild(list.children[Math.random() * i | 0]);
  }
}

function run_carousel() {
  const slides = document.querySelectorAll(".slide");
  for (let i = 0; i < slides.length; i++) {
    slides[i].style.display = "none";
  }
  index++;
  if (index > slides.length) index = 1;
  slides[index - 1].style.display = "block";
  setTimeout(run_carousel, 2000); // Change image every 2 seconds
}

randomise_list();
run_carousel();
<div id="slider">
  <img class="slide" src="https://via.placeholder.com/50x50/333333/cccccc?text=1">
  <img class="slide" src="https://via.placeholder.com/50x50/333333/cccccc?text=2">
  <img class="slide" src="https://via.placeholder.com/50x50/333333/cccccc?text=3">
</div>

Upvotes: 2

Fuzzy
Fuzzy

Reputation: 496

Using Math.random() like it is used here:

<img class="mySlides" src="pic1.jpg" />
<img class="mySlides" src="pic2.jpg" />
<img class="mySlides" src="pic3.jpg" />

<script>
var myIndex = 0;
carousel();

function carousel() {
  var i;
  var x = document.getElementsByClassName("mySlides");
  for (i = 0; i < x.length; i++) {
    x[i].style.display = "none";  
  }
  myIndex = getRandomInt(0, x.length - 1);
  x[myIndex].style.display = "block";  
  setTimeout(carousel, 2000); // Change image every 2 seconds
}

function getRandomInt(min, max) {
    min = Math.ceil(min);
    max = Math.floor(max);
    return Math.floor(Math.random() * (max - min + 1)) + min;
}
</script>

Upvotes: 1

Related Questions