CODEWITHSUNDEEP
pythonwindowswhitespacedouble-quoteswinscp
EllipticalInitial
EllipticalInitial

Reputation: 1270

Python double quotes in subprocess.Popen aren't working when executing WinSCP scripting

I am attempting to use the code from here https://stackoverflow.com/a/56454579 to upload files to a server with WinSCP from Python on Windows 10. The code looks like this:

import subprocess
path = r'C:\mp4s\Sci-Fi Light Flicker.mp4'

process = subprocess.Popen(
  ['C:\Program Files (x86)\WinSCP\WinSCP.com', '/ini=nul', '/command', 'option batch abort', 'option confirm off', 'open ftp://user:[email protected]', f'put "{path}"', 'exit'],
  stdout=subprocess.PIPE, stderr=subprocess.PIPE)
for line in iter(process.stdout.readline, b''):
  print(line.decode().rstrip())

I get the output:

batch           abort
confirm         off
Connecting to ftp.website.com ...
Connected
Starting the session...
Session started.
Active session: [1] [email protected]
File or folder '\C:\mp4s\Sci-Fi' does not exist.
System Error.  Code: 123.
The filename, directory name, or volume label syntax is incorrect
(A)bort, (R)etry, (S)kip, Ski(p) all: Abort

Which tells me that the put command isn't properly handling the spaces in the filename. What do I need to change to get this to work? Removing the double quotes around the path gives me a different error (it thinks I'm trying to upload multiple files).

Upvotes: 2

Views: 967

Answers (1)

Martin Prikryl
Martin Prikryl

Reputation: 202504

I do not think you can use an array to provide arguments to WinSCP. The subprocess.Popen escapes double quotes in the arguments using backslash, what conflicts with double double-quotes escaping expected by WinSCP.

You will have to format the WinSCP command-line on your own:

args =  "\"C:\Program Files (x86)\WinSCP\WinSCP.com\" /ini=nul " + \
       f"/command \"open ftp://user:[email protected]\" \"put \"\"{path}\"\"\" exit"

(note that I've omitted your option commands, as they are defaults anyway)

Upvotes: 3

Related Questions