CODEWITHSUNDEEP
c#asp.net-core.net-coreasp.net-core-mvc.net-5
Adnan
Adnan

Reputation: 95

Redirect to page OnActionExecuting method ASP.NET Core 5 MVC

I have an issue that the request redirected too many times and I just want to go to new redirect route, so how can I prevent that or is there something that I am not aware of?

public class AuthController : Controller
{
    public override void OnActionExecuting(ActionExecutingContext filterContext)
    {
        base.OnActionExecuting(filterContext);

        if (GoToLogin)
        {
            filterContext.Result = new RedirectToRouteResult(new RouteValueDictionary
            {
                { "controller", "account" },
                { "action", "login" }
            });
        }
    }
}

Upvotes: 5

Views: 2195

Answers (2)

King King
King King

Reputation: 63327

The loop of redirecting is fairly clear. Your redirected request must be identifiable so that your code can check and does not perform the redirection for that redirected request (so no loop will be executed and cause the too-many-redirect error).

Your code can be just simple like this:

public override void OnActionExecuting(ActionExecutingContext filterContext)
{
    base.OnActionExecuting(filterContext);
    //obtain the controller instance
    var controller = context.Controller as Controller;

    //not sure where you define the GoToLogin here, I assume it's available as a bool
    GoToLogin &= !Equals(controller.TempData["__redirected"], true);
    if (GoToLogin)
    {
        //set a temp data value to help identify this kind of redirected request
        //which will be later sent by the client.
        //The temp data value will be deleted the next time read (the code above)
        controller.TempData["__redirected"] = true;

        filterContext.Result = new RedirectToRouteResult(new RouteValueDictionary
        {
            { "controller", "account" },
            { "action", "login" }
        });
    }
}

NOTE: the GoToLogin in your code is not clear, if you mean you don't know what condition for it (to prevent the loop of redirection), just set it like this:

var goToLogin = !Equals(controller.TempData["__redirected"], true);

Or to not mutate its value:

if (GoToLogin && !Equals(controller.TempData["__redirected"], true)){
   //redirect the request ...
}

The benefit of using TempData here is to make it auto-deleted after reading the first time. So at the time receiving back the redirected request, the value contained in TempData is true, making the whole GoToLogin false (or not met the condition to redirect) and the redirection will not be performed. After that the value contained in the TempData is cleared (deleted) and ready for the next time of redirection.

Upvotes: 4

Serge
Serge

Reputation: 43880

Try this:

filterContext.Result = new RedirectToActionResult ("<Action>", "<Controller>", null);
base.OnActionExecuting(filterContext);

Upvotes: 1

Related Questions