Codewars JavaScript fundamental problem help (Arrays)

Question

I've been trying to resolve the following problem:

You live in the city of Cartesia where all roads are laid out in a perfect grid. You arrived ten minutes too early to an appointment, so you decided to take the opportunity to go for a short walk. The city provides its citizens with a Walk Generating App on their phones -- everytime you press the button it sends you an array of one-letter strings representing directions to walk (eg. ['n', 's', 'w', 'e']). You always walk only a single block for each letter (direction) and you know it takes you one minute to traverse one city block, so create a function that will return true if the walk the app gives you will take you exactly ten minutes (you don't want to be early or late!) and will, of course, return you to your starting point. Return false otherwise.

Note: you will always receive a valid array containing a random assortment of direction letters ('n', 's', 'e', or 'w' only). It will never give you an empty array (that's not a walk, that's standing still!).

Here is the code I wrote:

function walkTime(walk) {
    //insert brilliant code here
    var walkLength = walk.length;
    if (walkLength === 10) {
      return true;
    }
    else {
      return false;
    }
  }

findEndPosition = (Arr) => {
    var y = 0
    if (Arr.length > 10) {
        return false
    }
    else {    
    Arr.forEach((x) => {
        if (x === 'n') {
            y++;
        }
        if (x === 's') {
            y--;
        }
        if (x === 'e') {
            y++;
        }
        if (x === 'w') {
            y--;
        }
    })
    };
    if (y === 0) {
        return true;
    }
    else {
        return false;
    }
}

const isValidWalk = (walk) => {
    if(walkTime(walk) === true && findEndPosition(walk) === true){
        return true
    }
    else {
        return false
    }
}


console.log(isValidWalk(['w','e','w','e','w','e','w','e','w','e','w','e']));

I keep trying to passing all the tests except for two. Unfortunately it's not telling me what inputs it's using that keep failing :/. Anyone think they know what's going on, this is driving me crazy! Thanks in advance!

Answer 1

Just wanted to let you guys know I found this solution. It worked through all the tests! I'm sure it could be written a lot better, if you guys got suggestions I'd appreciate it! Anyways here it is!

function walkTime(walk) {
    //insert brilliant code here
    var walkLength = walk.length;
    if (walkLength === 10) {
      return true;
    }
    else {
      return false;
    }
  }

const findEndPosition = (Arr) => {
    var y = 0;
    var x = 0;
    if (Arr.length > 10) {
        return false
    }
    else {    
    Arr.forEach((movement) => {
        if (movement === 'n') {
            y++;
        }
        if (movement === 's') {
            y--;
        }
        if (movement === 'e') {
            x++;
        }
        if (movement === 'w') {
            x--;
        }
    })
    };
    const newLocation = [x,y];
    if (newLocation.toString() === '0,0') {
        return true;
    }
    else {
        return false;
    }
}

const isValidWalk = (walk) => {
    if(walkTime(walk) === true && findEndPosition(walk) === true){
        return true
    }
    else {
        return false
    }
}

console.log(isValidWalk(['n','s','e','w','n','s','e','w','e','w']));

Answer 2

If your goal is only to check if the walk will take exactly 10 minutes, it should be enough to test that the walk array is 10 in length and the walk steps are valid. Isn't it so?

In your code, you have a function for solving the end position. There is a clear mistake as steps to west and east are changing the y variable. Is your actual problem more related to this one?