CODEWITHSUNDEEP
formsjquery
nkcmr
nkcmr

Reputation: 11010

form not following .live() bind

I have a form that has been generated after the document was loaded. and I am trying to stop submission with a return false; but it does not stop the form from reloading the document. here is my code:

$('#name-update.updateAcct').live('submit', function(){
    var action = $(this).attr('data-action');
    console.log(action);
    switch(action){
        case "name":
            var firstName = $(this).children('input#contct_firstName').val();
            var lastName = $(this).children('input#contct_lastName').val();
            console.log(firstName+" "+lastname);
            break;
    }
    return false;
});

I have no idea why this statement isn't stopping the form.

Upvotes: 0

Views: 101

Answers (2)

Darin Dimitrov
Darin Dimitrov

Reputation: 1039110

Here:

console.log(firstName+" "+lastname);

lastname doesn't exist (it should be lastName) => a javascript error is thrown => the .live function never has time to return false => the form submits normally.

As far as fetching those names are concerned I see that you are using id selectors and because ids in HTML should be unique you could simplify your life like this:

var firstName = $('#contct_firstName').val();
var lastName = $('#contct_lastName').val();

or:

var firstName = $('input#contct_firstName', this).val();
var lastName = $('input#contct_lastName', this).val();

but honestly, the shorter a code is, the smaller the probability of making errors are.

Upvotes: 2

SeanCannon
SeanCannon

Reputation: 77996

Try adding event.preventDefault(); to the top of your observer:

$('#name-update.updateAcct').live('submit', function(event){
    event.preventDefault(); // stop default form submission
    var action = $(this).attr('data-action');
    console.log(action);
    switch(action){
        case "name":
            var firstName = $(this).children('input#contct_firstName').val();
            var lastName = $(this).children('input#contct_lastName').val();
            console.log(firstName+" "+lastName);
            break;
    }
    return false;
});

Upvotes: 2

Related Questions