CODEWITHSUNDEEP
coldfusioncoldfusion-8
aparker81
aparker81

Reputation: 263

Uploading Multiple Files

I have a form where users are to upload at least three documents and up to seven. In its current state, I have all the error checking and validation functioning. What I want to happen is for the visitor's forms to get renamed a specified name once they are uploaded and placed into a specified directory. My code is here: http://pastebin.com/V5ThWe7M

I believe the issue occurs around line 456. I believe I need to have the file name stored in a variable then use the variable to process the renaming function. The first file gets uploaded but not the second as they are assigned the same names. I'm trying to figure out how to use the variables that store the individual file names and then use that variable to rename the file. I'd like to have another set of eyes check it out for me and point me in the right direction.

Thank you

Upvotes: 0

Views: 1265

Answers (2)

Nate
Nate

Reputation: 2881

EDIT: Adding some new code into the mix... :)

Here's some functions, just slap these in the top of your page...

<cffunction name="uploadFile">
    <cfargument name="formField" hint="Form field name that holds the file to be uploaded" required="yes">
    <cfargument name="renameTo" hint="What to rename the file, ex: 01_nominationLetter" required="yes">
    <cfargument name="uploadErrorMessage" required="no" default="Error uploading file"/>
    <cfargument name="allowedExtensions" required="no" default="doc,docx,pdf,txt,rt">
    <cfargument name="extensionErrorMessage" required="no" default="Only doc, docx, pdf, txt, and rtf file formats are accepted">
    <cfset var dir = expandPath("./nominationUploads/#trim(form.fname)#_#trim(form.lname)#/")>
    <cfparam name="request.filesUploaded" default="#arrayNew(1)#">
    <cftry>
        <cffile action="upload" filefield="#arguments.formField#" nameconflict="makeunique" destination="#dir#">
        <cfcatch type="any"><cfset ArrayAppend(arrErrors, arguments.uploadErrorMessage )></cfcatch>
    </cftry>
    <cfif not listFindNoCase(arguments.allowedExtensions, cffile.ServerFileExt)>
        <cfset ArrayAppend(arrErrors, arguments.extensionErrorMessage )>
    </cfif>
    <cffile action="rename" file="#dir##cffile.serverFile#" destination="#dir##renameTo#.#cffile.ServerFileExt#">
    <cfset ArrayAppend(request.filesUploaded, dir & arguments.renameTo & "." & cffile.ServerFileExt )>
</cffunction>

<cffunction name="removeFilesOnError">
    <cfloop from="1" to="#arrayLen(request.filesUploaded)#" index="i">
        <cftry><cffile action="delete" file="#request.filesUploaded[i]#"/><cfcatch type="any"></cfcatch></cftry>
    </cfloop>
</cffunction>

Then in your existing validation script, get rid of all the file stuff, instead you'll only need to use those functions above, something like this : 

<cfset uploadFile('myFileField',  'renameToThis'  )>
<cfset uploadFile('myFileField2', 'renameToThat' , 'My custom upload error!')>
<cfset uploadFile('anotherFile',  'differentName', 'Another custom upload msg!', 'doc,docx', 'This one only lets you upload word docs!')>

<cfif arrayLen( arrErrors ) >
    <cfset removeFilesOnError()>
</cfif>

I don't have time to test the above, but I believe it to be frighteningly close. If you encounter an issue, let me know and I'll help you debug it out. :)

Upvotes: 1

Leigh
Leigh

Reputation: 28873

As already mentioned, the CFFILE structure is overwritten each time you upload. So any values you wish to preserve, you must save to another variable. But since you are already saving the full file names to a variable, you could easily extract their extensions using list functions. For example:

     <cfset nomExt = listLast(clientNominationLetter, ".")>

A few other observations

  • Consider a more unique naming scheme for your folders than "/firstName_lastName/". Otherwise, you may end up overwriting someone's files if you receive multiple submissions under the same name, like two different "John Smith's".

  • The cffile values are separated into two categories: cffile.serverXX and cffile.clientXX (ie user system). They are not interchangeable. So be sure you are using the correct variables and be consistent.

  • FILE is deprecated. Use CFFILE or the result attribute instead.

Upvotes: 1

Related Questions