Dan
Dan

Reputation: 2886

In C++, does initializing a global variable with itself have undefined behaviour?

int i = i;

int main() { 
 int a = a;
 return 0;
} 

int a = a surely has undefined behaviour (UB), and more details on it is in Is reading an uninitialized value always an undefined behaviour? Or are there exceptions to it?.

But what about int i = i? In C++ we are allowed to assign nonconstant values to globals. i is declared and zero initialized (since it has file scope) before the declaration is encountered. In which case we are assigning 0 to it later in the definition. Is it safe to say this does not have UB?

Upvotes: 68

Views: 4786

Answers (4)

Jan Schultke
Jan Schultke

Reputation: 40094

While the given answers provide plausible explanations, there is no definitive answer. Your question boils down to CWG Issue 2821: Lifetime, zero-initialization, and dynamic initialization . In the case of

int i = i;

... there are three possible interpretations, none of which is obviously wrong:

  1. Zero-initialization begins the lifetime of i, and then dynamic initialization would modify the value of i ([defns.access]).

  2. Zero-initialization begins the lifetime of i, and then dynamic initialization transparently replaces ([basic.life]) i with a completely new object.

  3. Zero-initialization does not begin the lifetime of i, meaning that i on the right-hand side is performing a value computation of an object whose lifetime hasn't started. This would be undefined behavior.

In any case, the committee seems intent on making this int i = i; valid; the question is just how that would be put into words.

On the other hand,

int main() {
    int a = a;
}

... is obviously undefined behavior because during this copy-initialization, the lvalue a is used to access a ([basic.life] p7.1), but the lifetime of a hasn't yet begun. Zero-initialization does not bail us out here.

Upvotes: 3

xmh0511
xmh0511

Reputation: 7369

It appears to me int i = i; has undefined behavior, is not caused by the indeterminate value. The term indeterminate value is designed for the objects that have automatic or dynamic storage duration.

[basic.indet#1]

When storage for an object with automatic or dynamic storage duration is obtained, the object has an indeterminate value, and if no initialization is performed for the object, that object retains an indeterminate value until that value is replaced ([expr.ass]).

[basic.indet#2]

If an indeterminate value is produced by an evaluation, the behavior is undefined except in the following cases...

In your example, the object named i has a static storage duration, hence it is not within the extent of talking about indeterminate value. And, such an object has a zero-initialization that happens before any dynamic initialization as per [basic.start.static#2]

Together, zero-initialization and constant initialization are called static initialization; all other initialization is dynamic initialization. All static initialization strongly happens before ([intro.races]) any dynamic initialization.

Hence, its initial value is zero. when i is used as an initializer to initialize itself. which is a dynamic initialization and it obeys [dcl.init].

Otherwise, the initial value of the object being initialized is the (possibly converted) value of the initializer expression.

It violates the rule in [basic.lifetime]

The program has undefined behavior if:

  • the glvalue is used to access the object, or

Upvotes: 1

HolyBlackCat
HolyBlackCat

Reputation: 96906

The behavior might be undefined for i, since depending on how you read the standard, you could be reading i before its lifetime starts.

[basic.life]/1.2

... The lifetime of an object of type T begins when:

— its initialization (if any) is complete ...

As mentioned in the other answer, i is initialized twice: first zero-initialized statically, then initialized with i dynamically.

Which initialization starts the lifetime? The first one or the final one?

The standard is being vague, and there are conflicting notes in it (albeit all of them are non-normative). Firstly, there is a footnote in [basic.life]/6 (thanks @eerorika) that explicitly says that the dynamic initialization starts the lifetime:

[basic.life]/6

Before the lifetime of an object has started but after the storage which the object will occupy has been allocated26

...

26) For example, before the dynamic initialization of an object with static storage duration ...

This interpretation makes the most sense to me, because otherwise it would be legal to access class instances before they undergo dynamic initialization, before they could estabilish their invariants (including the standard library classes defined by the standard).

There's also a conflicting note in [basic.start.static]/3, but that one is older than the one I mentioned above.

Upvotes: 7

Sam Varshavchik
Sam Varshavchik

Reputation: 118435

Surprisingly, this is not undefined behavior.

Static initialization [basic.start.static]

Constant initialization is performed if a variable or temporary object with static or thread storage duration is constant-initialized. If constant initialization is not performed, a variable with static storage duration or thread storage duration is zero-initialized. Together, zero-initialization and constant initialization are called static initialization; all other initialization is dynamic initialization. All static initialization strongly happens before any dynamic initialization.

Important parts bold-faced. "Static initialization" includes global variable initialization, "static storage duration" includes global variables, and the above clause is applicable here:

int i = i;

This is not constant-initialization. Therefore, zero-initialization is done according to the above clause (for basic integer types zero-initialization means, unsurprising, that it's set to 0). The above clause also specifies that zero initialization must take place before dynamic initialization.

So, what happens here:

  1. i is initialized to 0.
  2. i is then dynamically initialized, from itself, so it still remains 0.

Upvotes: 60

Related Questions