CODEWITHSUNDEEP
c#unity-game-engine
Tudoraster
Tudoraster

Reputation: 121

I want to lerp weapon / object position to a specific player offset, parented to the fps camera unity

I have a fps controller structured like this:

this is the hierarchy

Whenever I press e on a pickup weapon prefab, I want to move the weapon to a predefined offset and be the parent of the "Weapons" gameobject under camera.

I have structured the project like this:

public class WeaponPickup : MonoBehaviour
{
    [SerializeField] private Weapon weapon;

    public void PickUpWeapon(Fighter fighter)
    {
        fighter.EquipWeapon(weapon, transform.position, transform.rotation);
        Destroy(gameObject);
    }
}

public void EquipWeapon(Weapon weapon, Vector3 pickupPosition, Quaternion pickupRotation)
{
    if (currentWeapon != null)
    {
        currentWeapon.weaponGO.SetActive(false);
    }

    currentWeapon = weapon;
    weaponList.Add(currentWeapon);
    currentWeaponIndex = weaponList.Count - 1;

    currentWeapon.Spawn(pickupPosition, weaponsParent, this);
}

public void Spawn(Vector3 pickupPosition, Transform weaponParent, Fighter fighter)
{
    if (weaponPrefab != null)
    {
        weaponGO = Instantiate(weaponPrefab);

        fighter.MoveToPos(pickupPosition, weaponParent.TransformPoint(weaponPosition), 1f, weaponGO.transform, weaponParent);
    }
}

--

public void MoveToPos(Vector3 startPosition, Vector3 endPosition, float duration, Transform goTransform, Transform weaponParent)
{
    StartCoroutine(LerpPosition(startPosition, endPosition, duration, goTransform, weaponParent));
}

private IEnumerator LerpPosition(Vector3 startPosition, Vector3 endPosition, float duration, Transform goTransform, Transform weaponParent)
{
    float time = 0;
    goTransform.position = startPosition;
    while (time < duration)
    {
        goTransform.position = Vector3.Lerp(startPosition, endPosition, time / duration);
        time += Time.deltaTime;
        yield return null;
    }
    goTransform.position = endPosition;

    goTransform.parent = weaponParent.transform;
}

And the question is when I start the game and pick up the weapon, the weapon appears to lerp from the pickup position to the correct position but then it teleports to a random position.

Other info:

My guess it's that I am not changing correctly the localPosition / world position respectively as the object becomes parented at the end of the lerping.

If you need any other info, please don't hesitate to ask. Any suggestions are greatly appreaciated.

Upvotes: 2

Views: 208

Answers (2)

Tudoraster
Tudoraster

Reputation: 121

I actually found out what the problem was, I should have used Transform.InverseTransformPoint insted of Transform.TransformPoint.

Upvotes: 1

Kegan Heiss
Kegan Heiss

Reputation: 1

Huh. At first glance your code looks like it should do what you want. I'd recommend adding some Debug.Log lines to track the local and global positions before and after the parent assignment, out of curiosity. It does seem like it's a local/global positioning issue.

You could try using:

goTransform.SetParent(weaponParent.transform, false);

instead of:

goTransform.parent = weaponParent.transform;

The 'false' bool in SetParent refers is for the 'worldPositionStays' parameter, which seems like it should do the opposite of what your desired result, but since the opposite of your desired result is already happening, maybe that will work?

Upvotes: 0

Related Questions