CODEWITHSUNDEEP
java
Drinter
Drinter

Reputation: 51

Why 2 similar loop codes costs different time in java

I was confused by the codes as follows:

 public static void test(){
        long currentTime1 = System.currentTimeMillis();

        final int iBound = 10000000;
        final int jBound = 100;
        for(int i = 1;i<=iBound;i++){
            int a = 1;
            int tot = 10;
            for(int j = 1;j<=jBound;j++){
                tot *= a;
            }
        }


        long updateTime1 = System.currentTimeMillis();
        System.out.println("i:"+iBound+" j:"+jBound+"\nIt costs "+(updateTime1-currentTime1)+" ms");
    }

That's the first version, it costs 443ms on my computer.

first version result

 public static void test(){
        long currentTime1 = System.currentTimeMillis();

        final int iBound = 100;
        final int jBound = 10000000;
        for(int i = 1;i<=iBound;i++){
            int a = 1;
            int tot = 10;
            for(int j = 1;j<=jBound;j++){
                tot *= a;
            }
        }


        long updateTime1 = System.currentTimeMillis();
        System.out.println("i:"+iBound+" j:"+jBound+"\nIt costs "+(updateTime1-currentTime1)+" ms");
    }

The second version costs 832ms. second version result The only difference is that I simply swap the i and j.

This result is incredible, I test the same code in C and the difference in C is not that huge.

Why is this 2 similar codes so different in java?

My jdk version is openjdk-14.0.2

Upvotes: 2

Views: 154

Answers (3)

Stephen C
Stephen C

Reputation: 718678

TL;DR - This is just a bad benchmark.

I did the following:

  • Create a Main class with a main method.

  • Copy in the two versions of the test as test1() and test2().

  • In the main method do this:

    while(true) {
    test1();
    test2();
}

Here is the output I got (Java 8).

i:10000000 j:100
It costs 35 ms
i:100 j:10000000
It costs 33 ms
i:10000000 j:100
It costs 33 ms
i:100 j:10000000
It costs 25 ms
i:10000000 j:100
It costs 0 ms
i:100 j:10000000
It costs 0 ms
i:10000000 j:100
It costs 0 ms
i:100 j:10000000
It costs 0 ms
i:10000000 j:100
It costs 0 ms
i:100 j:10000000
It costs 0 ms
i:10000000 j:100
It costs 0 ms
....

So as you can see, when I run two versions of the same method alternately in the same JVM, the times for each method are roughly the same.

But more importantly, after a small number of iterations the time drops to ... zero! What has happened is that the JIT compiler has compiled the two methods and (probably) deduced that their loops can be optimized away.

It is not entirely clear why people are getting different times when the two versions are run separately. One possible explanation is that the first time run, the JVM executable is being read from disk, and the second time is already cached in RAM. Or something like that.

Another possible explanation is that JIT compilation kicks in earlier1 with one version of test() so the proportion of time spent in the slower interpreting (pre-JIT) phase is different between the two versions. (It may be possible to teas this out using JIT logging options.)

But it is immaterial really ... because the performance of a Java application while the JVM is warming up (loading code, JIT compiling, growing the heap to its working size, loading caches, etc) is generally speaking not important. And for the cases where it is important, look for a JVM that can do AOT compilation; e.g. GraalVM.

1 - This could be because of the way that the interpreter gathers stats. The general idea is that the bytecode interpreter accumulates statistics on things like branches until it has "enough". Then the JVM triggers the JIT compiler to compile the bytecodes to native code. When that is done, the code runs typically 10 or more times faster. The different looping patterns might it reach "enough" earlier in one version compared to the other. NB: I am speculating here. I offer zero evidence ...

The bottom line is that you have to be careful when writing Java benchmarks because the timings can be distorted by various JVM warmup effects.

For more information read: How do I write a correct micro-benchmark in Java?

Upvotes: 3

pouya
pouya

Reputation: 144

you found the answer in algorithm books first chapter :

cost of producing and assigning is 1. so in first algorithm you have 2 declaration and assignation 10000000 and in second one you make it 100. so you reduce time ...

in first : 5 in main loop and 3 in second loop -> second loop is : 3*100 = 300 then 300 + 5 -> 305 * 10000000 = 3050000000

in second : 3*10000000 = 30000000 - > (30000000 + 5 )*100 = 3000000500

so the second one in algorithm is faster in theory but I think its back to multi cpu's ...which they can do 10000000 parallel job in first but only 100 parallel job in second .... so the first one became faster.

Upvotes: 0

Elikill58
Elikill58

Reputation: 4908

I test it myself, I get same difference (around 16ms and 4ms).

After testing, I found that :

Declare 1M of variable take less time than multiple by 1 1M time.

How ?

I made a sum of 100

final int nb = 100000000;
for(int i = 1;i<=nb;i++){
   i *= 1;
   i *= 1;
[... written 20 times]
   i *= 1;
   i *= 1;
}

And of 100 this:

final int nb = 100000000;
for(int i = 1;i<=nb;i++){
   int a = 0;
   int aa = 0;
[... written 20 times]
   int aaaaaaaaaaaaaaaaaaaaaa = 0;
   int aaaaaaaaaaaaaaaaaaaaaaa = 0;
}

And I respectively get 8 and 3ms, which seems to correspond to what you get.

You can have different result if you have different processor.

Upvotes: 2

Related Questions