CODEWITHSUNDEEP
vb6
user17118075
user17118075

Reputation:

Expected Function or variable vb6.0

Hello i am coding in Visual Basic 6.0 and i have this error, i am trying to make a button inserting data in database.

Expected Function or variable

This is my code

Private Sub Command1_Click()
With ConString.Recordset.AddNew
 !ID = txtID
 !Emri = txtEmri
 !Mbiemri = txtMbiemri
 !Datelindja = txtData
 !Telefon = !txtTelefon
 !Gjinia = gender
 !Punesuar = job
 !Martese = cmbMartese
 !Vendlindja = txtVendlindje
 End With
End Sub

txtID is textbox
txtEmri is textbox
txtMbiemri is textbox
txtData is date picker
txtTelefon is textbox
gender is a string that takes value if a radio button is clicked
job is an integer if a checkbox is clicked
cmbMartese is combo box
txtVendlindje is textbox

Thank you in advance.

Upvotes: 1

Views: 130

Answers (1)

Hel O'Ween
Hel O'Ween

Reputation: 1486

@JohnEason gave you the right answer. But there's another error in the line !Telefon = !txtTelefon, if I'm not mistaken. It should read !Telefon = txtTelefon, i.e. without the exclamation mark in front of txtTelefon.

I'm also not a big fan of that coding style. I prefer to not rely on default properties, but instead "spell out" the whole term, e.g.

With ConString.Recordset
 .AddNew
 !ID = txtID.Text
 !Emri = txtEmri.Text
 !Mbiemri = txtMbiemri.Text
 !Datelindja = txtData.Text
 !Telefon = txtTelefon.Text
 ' Since VB6 doesn't provide Intellisense for variables, I prefer to use some
 ' kind of hungarian notation for variable names, in this case sGender or strGender for a string variable
 !Gjinia = gender
 ' Same here: iJob or intJob for an integer variable
 !Punesuar = job
 ' You need to specify that you want the selected item of a combobox
 !Martese = cmbMartese.List(cmbMartese.ListIndex)
 !Vendlindja = txtVendlindje.Text
 ' If you're done setting column values and don't do so somewhere else, 
 ' you also need to add a .Update statement here in order to finish the 
 ' .AddNew action and actually persist the data to the database.
 ' .Update
 End With
End Sub

As pointed out below by @JohnEason, there's also potentially an .Update statement missing within the With/End With block

Upvotes: 2

Related Questions