CODEWITHSUNDEEP
phpmysqlpdo
Alex Knopp
Alex Knopp

Reputation: 935

MySQL Syntax Error when using JSON array as value

My Table:

Expected values

The following SQL works as expected. Great!

 -- Insert a new row into the purchased products table
INSERT INTO dc_purchased_products (
    user_id, -- INT
    purchased_products -- JSON
)

-- 1) The user ID (primary key)
-- 2) Formatted json array with the first purchased product ID
VALUES ( 12345, '["36"]' )

-- If the user id already exists, append the existing array with the product ID
ON DUPLICATE KEY UPDATE 

-- JSON_ARRAY_INSERT(existing purchases array, index, product_id)
purchased_products = JSON_ARRAY_INSERT(purchased_products, '$[0]', "36")

However, my PDO satements in my application arent so good.

$item = [
  'statement' => "INSERT INTO purchased_products 
                        (customer_id, purchased_products) 
                  VALUES(:customer_id, [:purchased_products]) 
                    ON DUPLICATE KEY 
                    UPDATE purchased_products = JSON_ARRAY_INSERT(purchased_products, '$[0]',:purchased_products)",
  'data' => [
    ['customer_id' => 12345, 'purchased_products' => '"36"'],
    ['customer_id' => 12345, 'purchased_products' => '"37"']
  ]
]

My Connection

$this->connection = new PDO("mysql:host=$servername;dbname=$database", $u, $p, [
  PDO::MYSQL_ATTR_SSL_KEY                => $ck,
  PDO::MYSQL_ATTR_SSL_CERT               => $cc,
  PDO::MYSQL_ATTR_SSL_CA                 => $sc,
  PDO::MYSQL_ATTR_SSL_VERIFY_SERVER_CERT => false,
]);

$this->connection->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);


$statement = $this->connection->prepare($item['statement']);
foreach ($item['data'] as $rowData) {

    foreach ($rowData as $key => $param) {
        $statement->bindValue(':' . $key, $param);
    }

    try {
        $success = $statement->execute();
    }

    catch (PDOException $e) {
        pre($e->getMessage());        
    }

}

Error message

SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '['3784835']) ON DUPLICATE KEY UPDATE purchased_products = JSON_ARRAY_INSERT(purc' at line 1

Upvotes: 1

Views: 794

Answers (1)

masterguru
masterguru

Reputation: 577

This should fix the problem:

$item = [
  'statement' => "INSERT INTO purchased_products 
                        (customer_id, purchased_products) 
                  VALUES(:customer_id, :purchased_products) 
                    ON DUPLICATE KEY 
                    UPDATE purchased_products = JSON_ARRAY_INSERT(purchased_products, '$[0]',:purchased_products_json)",
  'data' => [
    ['customer_id' => 12345, 'purchased_products' => '["36"]', 'purchased_products_json' => '36'],
    ['customer_id' => 12345, 'purchased_products' => '["37"]', 'purchased_products_json' => '37'],
  ]
];

Explanation of changes:

Removed [ and ] in VALUES(:customer_id, [:purchased_products])

Now it looks like this:

VALUES(:customer_id, :purchased_products)

This change will avoid the error during the execute().

New param in JSON_ARRAY_INSERT: purchased_products_json

Now it looks like this:

JSON_ARRAY_INSERT(purchased_products, '$[0]',:purchased_products_json)

To avoid the error now we need two params with small diferences. One for the INSERT (purchased_products) and other for the UPDATE (purchased_produtcs_json) because they have different formats despite same values.

In data array, changed 'purchased_products' => '"36"'

Now it looks like this:

'purchased_products' => '["36"]'

because we will use it during INSERT stament, and we need to set it as new JSON array value with correct format and because we already removed the [ and ] in the previous INSERT statement.

In data array, added new param: 'purchased_products_json'

In order to UPDATE the field, the value format should be different, so we need this new param. It looks like this:

'purchased_products_json' => '36'

avoiding the use of [ and ]. You can see some information about JSON_ARRAY_INSERT in mariadb documentation

Upvotes: 2

Related Questions