CODEWITHSUNDEEP
javascriptswitch-statement
SzyMly
SzyMly

Reputation: 3

JavaScript - begginner questions

I have some difficulties with my first number guessing "game" in JavaScript. Can someone have a look and guide me what I did wrong? Started with that language not that long ago..

Function is assigned to one button

<input id="box;" class="btn" ; type="button" value="Guess" onClick="check()">Click to start !

User (player) have to press the button, guess the number (1-10) within 3 attemps and then play again or not. Every attemp I do it says "number is higher" but at the end result is random, even if you chose 10.

var hiddenNum;
var attemps;

hiddenNum = Math.floor(Math.random() * 10);
hiddenNum = hiddenNum + 1;
attemps = 0;


    function check(guess) {
        window.prompt("Please enter the number between 1 and 10", "10");

        if (hiddenNum == guess) {
            window.alert("Congratulations! You guessed correctly !");

            again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

            if (again == "N" || again == "n") {
                window.alert("Thanks for trying. Goodbye.");
                window.close();
            } else {
                window.alert("The number has been randomized.");
                window.location.reload();
            }

        } else {
            attemps = attemps + 1;

            if (hiddenNum < guess) {
                result = "lower";
            } else {
                result = "higher";
            }

            window.alert("Guess number " + attemps + " is incorrect. The number is " + result + ".");

        }

        if (attemps >= 3) {
            window.alert("Sorry, you have run out of guesses! The number was " + hiddenNum);

            again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

            if (again == "N" || again == "n") {
                window.alert("Thanks for trying. Goodbye.");
                window.close();
            } else {
                window.alert("The number has been randomized.");
                window.location.reload();
            }

        }

    }

Upvotes: 0

Views: 89

Answers (4)

devNull
devNull

Reputation: 1

Noticed you never declared 'result'. So I made that variable into a ternary operator to shorten up your code a little more. Also, I added template literals :)

let hiddenNum = Math.floor(Math.random() * 10);
//console.log(hiddenNum);
hiddenNum = hiddenNum;
let attempts = 0;

const nextRound = function () {
  let again = window.prompt('Would you like to try again? Enter Y or N.');
  if (again.toUpperCase() === 'N') {
    window.alert("Thank's for trying. Later nerd");
    window.close();
  } else {
    window.alert('Try to guess the new number, nerd.');
    window.location.reload();
  }
};

function check() {
  let guess = prompt('Please enter the number between 1 and 10');
  console.log(guess);

  if (hiddenNum === guess) {
    alert('Congratulations! You guessed correctly !');

    nextRound();
  } else {
    attempts++;

    let result = hiddenNum < guess ? 'lower' : 'higher';

    alert(`Guess number is ${attempts} is incorrect. The number is ${result}.`);
  }
  if (attempts >= 3) {
    alert(`Sorry, you have run out of guesses! The number was ${hiddenNum}`);

    nextRound();
  }
}
<div>
      <input
        id="box"
        class="btn"
        style="
          display: inline-block;
          border-radius: 2em;
          box-sizing: border-box;
          color: white;
          background-color: blueviolet;
          cursor: pointer;
        "
        type="button"
        value="Guess"
        onClick="check()"
      />Click to start !
    </div>

Upvotes: 0

James
James

Reputation: 2787

You should store the value from window.prompt. In your code, you just use guess in the parameter of the function as the value of window.prompt which is incorrect.

Syntax for window.promp:

result = window.prompt(message, default);

Also, I have shorten your codes and store the duplicate item in a function to make it a little bit less messy.

function smallcheck() {
  let again = window.prompt("Would you like to try again? Enter Y or N.", "Y");
  if (again.toUpperCase() == "N") {
    window.alert("Thanks for trying. Goodbye.");
    window.close();
  } else {
    window.alert("The number has been randomized.");
    window.location.reload();
  }
}

function check() {
  let guess = window.prompt("Please enter the number between 1 and 10", "10");
  console.log(guess)
  if (hiddenNum == guess) {
    window.alert("Congratulations! You guessed correctly !");

    smallcheck()

  } else {
    attempts++;

    if (hiddenNum < guess) {
      result = "lower";
    } else {
      result = "higher";
    }
    window.alert("Guess number " + attempts + " is incorrect. The number is " + result + ".");

  }
  if (attempts >= 3) {
    window.alert("Sorry, you have run out of guesses! The number was " + hiddenNum);

    smallcheck()

  }

}

Upvotes: 0

DCR
DCR

Reputation: 15700

you need to assign the prompt

var hiddenNum;
var attemps;

hiddenNum = Math.floor(Math.random() * 10);
hiddenNum = hiddenNum + 1;
attemps = 0;



    function check() {
    
        let guess = window.prompt("Please enter the number between 1 and 10", "10");
      
        if (hiddenNum == guess) {
            window.alert("Congratulations! You guessed correctly !");

            again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

            if (again == "N" || again == "n") {
                window.alert("Thanks for trying. Goodbye.");
                window.close();
            } else {
                window.alert("The number has been randomized.");
                window.location.reload();
            }

        } else {
            attemps = attemps + 1;

            if (hiddenNum < guess) {
                result = "lower";
            } else {
                result = "higher";
            }

            window.alert("Guess number " + attemps + " is incorrect. The number is " + result + ".");

        }

        if (attemps >= 3) {
            window.alert("Sorry, you have run out of guesses! The number was " + hiddenNum);

            again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

            if (again == "N" || again == "n") {
                window.alert("Thanks for trying. Goodbye.");
                window.close();
            } else {
                window.alert("The number has been randomized.");
                window.location.reload();
            }

        }

    }
<input id="box;" class="btn" ; type="button"  value='guess'onClick="check()">Click to start!
User (player) have to press the button, guess the number (1-10) within 3 attemps and then play again or not. Every attemp I do it says "number is higher" but at the end result is random, even if you chose 10.

Upvotes: 0

Esszed
Esszed

Reputation: 607

You designed your check function to have a guess passed to it but you are just calling it without doing so. So all your comparisons are against undefined.

You are also using window.prompt to get the actual guess. What you need to do is save the value returned from the prompt into a variable and then compare it. Check the snippet.

var hiddenNum;
var attemps;

hiddenNum = Math.floor(Math.random() * 10);

hiddenNum = hiddenNum + 1;
attemps = 0;

function check() {
  let guess = window.prompt("Please enter the number between 1 and 10", "10");

  if (hiddenNum == guess) {
    window.alert("Congratulations! You guessed correctly !");

    again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

    if (again == "N" || again == "n") {
      window.alert("Thanks for trying. Goodbye.");
      window.close();
    } else {
      window.alert("The number has been randomized.");
      window.location.reload();
    }
  } else {
    attemps = attemps + 1;

    if (hiddenNum < guess) {
      result = "lower";
    } else {
      result = "higher";
    }

    window.alert(
      "Guess number " + attemps + " is incorrect. The number is " + result + "."
    );
  }

  if (attemps >= 3) {
    window.alert(
      "Sorry, you have run out of guesses! The number was " + hiddenNum
    );

    again = window.prompt("Would you like to try again? Enter Y or N.", "Y");

    if (again == "N" || again == "n") {
      window.alert("Thanks for trying. Goodbye.");
      window.close();
    } else {
      window.alert("The number has been randomized.");
      window.location.reload();
    }
  }
}
<input id="box;" class="btn" ; type="button" value="Guess" onClick="check()">Click to start

Upvotes: 1

Related Questions