CODEWITHSUNDEEP
arraysc
Bob Jones
Bob Jones

Reputation: 61

Printing an array with separator commas

I'm trying to print the elements of an array separated by commas.

My output:

5,6,7,8,9,

I need to get rid of the last comma, anyone know how to do that?

#include <stdio.h>
#include <stdlib.h>

void print_array(int integers[], int  elements);

int main(){
    
    int arr[5] = {5, 6, 7, 8, 9};
    print_array(arr, 5);
    
    return 0;
    
}

void print_array(int integers[], int elements){
    
    int j; 
    for(j=0; j<elements; j++){
        printf("%d,", integers[j]);
        
    }
}

Upvotes: 6

Views: 1471

Answers (4)

einpoklum
einpoklum

Reputation: 131986

This is actually a frequent pattern in programming: You have a sequence of elements, and you want to do something both for every element and for every pair of consecutive element, i.e. for every gap between consecutive elements.

Anyway, here are a few options:

  1. Iterate all elements except the last one (knowing they each have a subsequent element), treat the last one separately.
  2. Treat the first element separately, then iterate all remaining elements (knowing they each have a preceding element).
  3. Iterate all elements, but check for whether you're at the first element.
  4. Iterate all elements, but check for whether you're at the last element.
  5. Iterate all elements, use a boolean to remember when you're already past the first element (i.e. you set the boolean when you find it to be false - so no need to be able to check the element to know whether it's the first or last etc.).
  6. Iterate all elements, acting as though they all had a subsequent element, then perform a corrective action to undo the work on the non-existing pair of subsequent elements at the end.

Here's an example for your case of the first option:

void print_array(int integers[], size_t num_elements)
{
    if (num_elements == 0) { return; }
    for(size_t j = 0; j < num_elements - 1; j++){
        printf("%d,", integers[j]);
    }
    printf("%d", integers[num_elements - 1]);
}

Notes:

  • It is tricky to avoid code duplication altogether with this pattern.
  • elements is a confusing name (it makes you think that variable has the actual elements), I replaced it with num_elements.
  • A similar question about C++: How can I print a list of elements separated by commas?

Upvotes: 5

pmg
pmg

Reputation: 108978

What I usually do is print the first element special avoiding a if inside the loop

void print_array(const int *integers, size_t elements, const char *pref, const char *postf) {
    if (pref) printf("%s", pref);
    printf("%d", integers[0]);              // 1st element
    for (size_t j = 1; j < elements; j++) {
        printf(", %d", integers[j]);        // 2nd, 3rd, ... elements
    }
    if (postf) printf("%s", postf);
}

int main(void) {
    int arr[5] = {5, 6, 7, 8, 9};
    print_array(arr, 5, 0, 0);
    print_array(arr, 5, "arr is {", "}\n");
    return 0;
}

Upvotes: 0

Marco
Marco

Reputation: 7287

Elaborating on einpoklum's answer, this is how I would do it (option 3):

#include <stdio.h>
#include <stdbool.h>

void print_array(int integers[], size_t num_elements) {
    for(size_t j = 0; j < num_elements; j++) {
        bool is_last_element = (j + 1) == num_elements;
        printf("%d", integers[j]);

        if (!is_last_element) {
            printf(",");
        }
    }
}

int main(void) {
    int ints[4] = {1,2,3,4};

    print_array(ints, 4);
}

This has the advantage of:

  • We don't have to check for zero elements.
  • The counter variable j stays local to the for-loop (this is arguably minor but still a plus)
  • No code duplication

Upvotes: 1

chux
chux

Reputation: 154255

Recommend to change the separator after printing.

void print_array(const int integers[], int elements) {
  const char *separator = ""; 
  for(int j=0; j<elements; j++) {
    printf("%s%d", separator, integers[j]);
    separator = ",";
  }
  printf("\n");
}

Notice this works well even if elements == 0 and does not need any special if() blocks or ?: statements.

Upvotes: 5

Related Questions