CODEWITHSUNDEEP
javascript
user15621717
user15621717

Reputation:

warning : function declared in a loop contains unsafe references to variable(s) ''

for (let i = 0; i < state.columns.length; i++) {
  var column = state.columns[i];
  var sortIndex;
  var fsColumn = firstSortColumns.find((v, i) => {
    sortIndex = i;
    return v.dataField === column.dataField;
  });
  if (fsColumn) {
    //...
  } else {
    //...
  }
}

Function declared in a loop contains unsafe references to variable(s) 'sortIndex', 'column'.

I am getting a warning like this, how can i fix this?

Upvotes: 2

Views: 5997

Answers (2)

Rahul
Rahul

Reputation: 11

Declare variables outside of the iteration (loop) and modify inside the for loop.

var column, fsColumn, sortIndex;
for (let i = 0; i < state.columns.length; i++) {
   column = state.columns[i];
   sortIndex;
   fsColumn = firstSortColumns.find((v, i) => {
    sortIndex = i;
    return v.dataField === column.dataField;
  });
  if (fsColumn) {
    //...
  } else {
    //...
  }
}

Upvotes: 1

Quentin
Quentin

Reputation: 944013

Your linter is being overly cautious here. Since the function you pass to find isn't called asynchronously, the fact the value of column can change isn't a problem.

If it were async then you could solve the problem by using let instead of var since it has block-scope instead of function-scope (and doing so would shut up your linter).

Upvotes: 4

Related Questions