CODEWITHSUNDEEP
javaxmlfile-io
bhalkian
bhalkian

Reputation: 499

reading xml file using FileInputStream

I am reading an XML file using the code given below, but every time I read the XML and print the same, the opening tag of XML is always missing, which in turn generates an error.

code to read xml :

package com.vaannila.action;

import java.io.File;
import java.io.FileInputStream;
import java.io.FileReader;

import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;

import org.apache.struts.action.Action;
import org.apache.struts.action.ActionForm;
import org.apache.struts.action.ActionForward;
import org.apache.struts.action.ActionMapping;

import com.vaannila.FormBean.XmlRetrivalForm;

public class AppletRefeshAction  extends Action {
    String filepath = "C:/Users/ashutosh_k/idoc/docRuleTool/WebContent/data/Malaria.xml";
    @Override
    public ActionForward execute(ActionMapping mapping, ActionForm form,
            HttpServletRequest request, HttpServletResponse response)
            throws Exception {
        XmlRetrivalForm xrf = (XmlRetrivalForm)form;
        String dieasename =xrf.getDieseasename();
        System.out.println("ghhjhhjkh"+dieasename);
        /* this part of the code is from jsp */
        //FileReader fis = new FileReader(new File(filepath));
        FileInputStream fis = new FileInputStream(new File(filepath));
        byte bin[] = new byte[(int) new File(filepath).length()];
        while(fis.read()>0){
        fis.read(bin);
        }
        System.out.println("I am here after reading the xml part of it ");
        response.setContentType("text/xml");
        response.setCharacterEncoding("UTF-8");
        response.getOutputStream().write(bin);
//      response.getWriter().write(bin);
        String ashu = new String(bin);
        String iam =ashu.trim();
        System.out.println("i am in the new action class now ");
        System.out.println(iam);
        fis.close();
        /* this part of the code jsp ends here */
        return null;
    }

}

The output xml generated :

?xml version="1.0" encoding="UTF-8" standalone="no"?><tree>
<declarations>
    <attributeDecl name="name" type="String"/>
</declarations>
<branch>
<branch>
<attribute name="name" value="Excess Stool"/>
<branch>
<branch>
<attribute name="name" value="Do you have this condition for more than a weeks time"/>
<branch>
<attribute name="name" value=""/></branch>
<branch>
<attribute name="name" value=""/></branch>
</branch>
<branch>
<attribute name="name" value="No"/></branch>
<attribute name="name" value="Do you have watery stool"/></branch>
<branch>
<attribute name="name" value="No"/></branch>
</branch>
<branch>
<branch>
<attribute name="name" value="Was your peak temperature greater than 104"/>
<branch>
<branch>
<attribute name="name" value="Do you have chills"/>
</branch>
<branch>
<attribute name="name" value="No"/></branch>
<attribute name="name" value="Do you have high fever for more than a weeks time "/></branch>
<branch>
<attribute name="name" value="No"/></branch>
</branch>
<branch>
<attribute name="name" value="No"/></branch>
<attribute name="name" value="High Fever"/></branch>
<branch>
<branch>
<attribute name="name" value="Do you have pain in the left part of the head "/>
<branch>
<branch>
<attribute name="name" value="Duration of the headache spans for more than a day "/>
</branch>
<branch>
<attribute name="name" value="No"/></branch>
<attribute name="name" value="Do you have headache more than 5 times a day "/></branch>
<branch>
<attribute name="name" value="No"/></branch>
</branch>
<branch>
<attribute name="name" value="No"/></branch>
<attribute name="name" value="Bodyache"/></branch>
<attribute name="name" value="Malaria"/></branch>
</tree>

Upvotes: 1

Views: 17124

Answers (2)

forty-two
forty-two

Reputation: 12817

First, you are reading into the byte buffer at the same offset in every loop iteration--you cannot expect to always read the entire file in one go. Second, don't unnecessarily convert between byte streams and character streams--you should read the XML as bytes and "forward" it as bytes. Be careful how you convert between byte arrays and strings--remember that new String(byte[]) uses the platform default character encoding (which may not be utf-8) to convert from bytes to characters.

// read the file
ByteArrayOutputStream out = new ByteArrayOutputStream(10000);
InputStream in = new BufferedInputStream(new FileInputStream(filepath));
int c;
while ((c = in.read()) != -1)
    out.write(c);
in.close();

// debug as string
if (debug) {
   System.out.writeln(new String(out.toBytes(), Charset.forName("utf-8"));
}


// forward to client through response
response.setContentType("text/xml");
response.setCharacterEncoding("UTF-8");
response.getOutputStream().write(out.toBytes());

Upvotes: 1

Mike Thomsen
Mike Thomsen

Reputation: 37506

Why this?

    FileInputStream fis = new FileInputStream(new File(filepath));
    byte bin[] = new byte[(int) new File(filepath).length()];
    while(fis.read()>0){
    fis.read(bin);
    }

instead of this to read the text?

BufferedReader reader = new BufferedReader(new FileReader(filepath));
String line = null;
StringBuilder builder = new StringBuilder();
while ( (line = reader.readLine()) != null)
    builder.append(line);
reader.close();

Upvotes: 2

Related Questions