CODEWITHSUNDEEP
php
jfer
jfer

Reputation: 3

Adding commas to a loop within a loop

I'm trying to create a list using a loop within a loop. I have 3 tables.

T1: faculty T2: keywords T3: facID, keywordID

I've created a select statement to cross join the rows and spit out something like this:

Faculty Name A
keyword-a keyword-b keyword-c

Faculty Name B
keyword-a keyword-d keyword-f

Everything works great except I need to add commas to the keyword list and my code isn't doing the trick. My keywords are still looping through without the comma.

 <?php while ($row = mysql_fetch_assoc($result)) { ?>

 <?php if ($row['facID'] !== $lastID ) { ?>
<?php echo $row['facname']; ?><br />
    <?php $lastID = $row['facID'];  ?> 
 <?php }  ?>

 <?php $kwords = array();
foreach($row as $k => $v) {
     if (strpos($k, 'kword') === 0) {
     $kwords[] = $v;
     }
  } 
  echo implode(', ', $kwords);

  }  ?>

Any suggestions? I'm a noob and I'm hoping it's something very obvious!

Upvotes: 0

Views: 195

Answers (1)

anon
anon

Reputation:

There seem to be a few issues with your code, so I'll try to address them all.

First, you have a lot of opening and closing <?php> tags, and it's really messing with the readability of your code. Consider keeping as much code as possible contained into a single <?php> code block. For example, instead of this:

 <?php if ($row['facID'] !== $lastID ) { ?>
<?php echo $row['facname']; ?><br />
    <?php $lastID = $row['facID'];  ?> 
 <?php }  ?>

...you can consolidate all of that PHP code into this:

<?php 
  if ($row['facID'] !== $lastID ) {
    echo $row['facname'] . "<br />";
    $lastID = $row['facID']; 
  }
?>

Next, you're not outputting any sort of visual break after echoing out your implode()ed array. This would lead to the next heading being output on the same line as the output of your previous heading. For example, your first two headings will end up like this:

Faculty Name A
keyword-a keyword-b keyword-cFaculty Name B
keyword-a keyword-d keyword-f

Notice how Faculty Name B is at the end of the line of keywords?

Finally, I think the problem you're reporting is that you're getting two keywords that are linked together. For example, if you had two rows of data with the same facility id, one with keywords keyword-a and keyword-b and another with keyword-c and keyword-d, you would see that output visually without a comma between keyword-b and keyword-c.

In other words, instead of this:

keyword-a, keyword-b, keyword-c, keyword-d

...you're instead seeing this:

keyword-a, keyword-bkeyword-c, keyword-d

This is also caused by the lack of a visual break between implodeed lines, but I believe the problem is deeper than that. I believe you want all keywords for a given facility to be shown on a single line, not broken across multiple lines. For that, you need to move where you reinitialize your array so that it gets reinitialized at the same time you switch to a new heading. Try something like this:

$kwords = array();
while ($row = mysql_fetch_assoc($result)) { 
  if ($row['facID'] !== $lastID ) {
    if ($kwords) {
      echo implode(", ", $kwords) . "<br />";
      $kwords = array();
    }
    echo $row['facname'] . "<br />";
    $lastID = $row['facID'];
  }
  foreach($row as $k => $v) {
    if (strpos($k, 'kword') === 0) {
      $kwords[] = $v;
    }
  }
}
if ($kwords) {
  echo implode(", ", $kwords);
}
echo "<br />";

This still isn't the best code, but you can refactor it.

The idea here is that the array gets output and reset every time the facility changes, so that the array encompasses all keywords for that facility and they all get output together, rather than being reported only as part of the database row they were returned with. After the loop completes, you have to manually report the last row since the usual reporting is taken care of within the loop.

Upvotes: 1

Related Questions