CODEWITHSUNDEEP
javaspring-bootspring-mvcget
Murtaza Hasan
Murtaza Hasan

Reputation: 333

@RequestMapping with "param" parameter not working correctly

I have the following spring-boot REST Controller:

@RestController
@AllArgsConstructor
public class AuditRecordArchivalHistoryController {
  private final AuditRecordArchivalHistoryService auditRecordArchivalHistoryService;

  @RequestMapping(value = "/archives", params = "pageNumber")
  public Mono<Slice<AuditRecordArchivalHistory>> findRecordsForAllTenants(
        @RequestParam (defaultValue = "0") Integer pageNumber)
    return 
      auditRecordArchivalHistoryService.findAllAuditRecordArchivalHistoryRecords(
            getPageable(pageNumber)
    );
}

@RequestMapping(value = "/archives", params = {"tenantId, pageNumber"} )
public Mono<Slice<AuditRecordArchivalHistory>> findRecordsForTenant(
        @RequestParam String tenantId,
        @RequestParam Integer pageNumber) {

    return 
      auditRecordArchivalHistoryService.findAuditRecordArchivalHistoryByTenantId(
            tenantId, getPageable(pageNumber)
    );
}

I expect that if I access the URL

/archives?pageNumber=1

the method: findRecordForAllTenants() would be called.

Whereas my expectation upon accessing the URL

/archives?tenantId=abc&pageNumber=1

is that the method: findRecordsForTenant() would be called.

However, in both the cases, the method findRecordsForAllTenants() is being called. Am I missing something?

Upvotes: 1

Views: 1788

Answers (3)

sj221
sj221

Reputation: 54

You have put "tenantId, pageNumber", it should be "tenantId", "pageNumber". You are missing quotes.

Upvotes: 1

白天明
白天明

Reputation: 46

I think this problem is because the parameters in params are written wrong, you can compare to what I wrote below.

@RequestMapping(value = "/archives", params = {"tenantId", "pageNumber"} )
public Mono<Slice<AuditRecordArchivalHistory>> findRecordsForTenant(
    @RequestParam String tenantId,
    @RequestParam Integer pageNumber) {
return auditRecordArchivalHistoryService.findAuditRecordArchivalHistoryByTenantId(
        tenantId, getPageable(pageNumber));
}

Upvotes: 3

Oleg
Oleg

Reputation: 77

Mast be like:

@RequestMapping(value = "/archives")
  public Mono<Slice<AuditRecordArchivalHistory>> findRecordsForAllTenants(
        @RequestParam (name="pageNumber", defaultValue = "0") Integer pageNumber)
    return 
      auditRecordArchivalHistoryService.findAllAuditRecordArchivalHistoryRecords(
            getPageable(pageNumber)
    );

Upvotes: -1

Related Questions