CODEWITHSUNDEEP
javascriptreactjs
ceaiius
ceaiius

Reputation: 179

How can I make this JS repetitive code shorter

I just wrote this piece of code that does the thing it's supposed to do, although it's really messy and pretty repetitive and I'm wondering how can I make it much shorter and concise.

if(id==1 && player == "playerOne"){
      Object.assign(playerOne, fighters[0])
    }else if(id==1 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[0])
    }
    if(id==2 && player == "playerOne"){
      Object.assign(playerOne, fighters[1])
    }else if(id==2 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[1])
    }
    if(id==3 && player == "playerOne"){
      Object.assign(playerOne, fighters[2])
    }else if(id==3 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[2])
    }
    if(id==4 && player == "playerOne"){
      Object.assign(playerOne, fighters[3])
    }else if(id==4 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[3])
    }
    if(id==5 && player == "playerOne"){
      Object.assign(playerOne, fighters[4])
    }else if(id==5 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[4])
    }
    if(id==6 && player == "playerOne"){
      Object.assign(playerOne, fighters[5])
    }else if(id==6 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[5])
    }
    if(id==7 && player == "playerOne"){
      Object.assign(playerOne, fighters[6])
    }else if(id==7 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[6])
    }
    if(id==8 && player == "playerOne"){
      Object.assign(playerOne, fighters[7])
    }else if(id==8 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[7])
    }
    if(id==9 && player == "playerOne"){
      Object.assign(playerOne, fighters[8])
    }else if(id==9 && player =="playerTwo"){
      Object.assign(playerTwo, fighters[8])
    }

Thank you in advance!

Upvotes: 0

Views: 71

Answers (4)

spender
spender

Reputation: 120380

Assuming

a) there are no more than two players

b) you don't care that this code handles id < 1 and id > 9

It looks to me like you could reduce this to a single line.

Object.assign(player == "playerOne" ? playerOne : playerTwo, fighters[id - 1])

Upvotes: 4

Stefan Jelner
Stefan Jelner

Reputation: 111

Based on the assumptions in your example, that id must be between 1 and 9 and player can be anything, but must be playerOne or playerTwo:

for (var i = 1; i < 10; i++) {
    if (id == i) {
        if(player == "playerOne"){
            Object.assign(playerOne, fighters[i - 1]);
        } else if (player == "playerTwo") {
            Object.assign(playerTwo, fighters[i - 1]);
        }
    }
}

Upvotes: 0

jabran jordan
jabran jordan

Reputation: 34

A for loop might be helpful:

for (let i = 1; i < 10; i++) {
  if (id == i && player == "playerOne") {
    Object.assign(playerOne, fighters[id - 1]);
  } else if (id == i && player == "playerTwo") {
    Object.assign(playerTwo, fighters[id - 1]);
  }
}

Upvotes: 0

Abhinav
Abhinav

Reputation: 39

What if you rewrite it to be something along the lines of

if (player == "playerOne") {
  p = playerOne
} else if (player =="playerTwo") {
  p = playerTwo
}
Object.assign(p, fighters[id - 1])

Upvotes: 0

Related Questions