CODEWITHSUNDEEP
vue.jsvuejs2vue-componentvue-routervue-options-api
SyedKhizer
SyedKhizer

Reputation: 241

Calling methods inside beforeRouteEnter NProgress

I am trying to call an API before navigating to the route. The problem is that if I try to call axios call inside beforeRouteEnter it is working fine for example:

{
  beforeRouteEnter(routeTo, routeFrom, next) {
    NProgress.start()
    axios.get('https://jsonplaceholder.typicode.com/posts').then((res) => {
      next((vm) => {
        vm.data = res.data
      })
      NProgress.done()
    })
  },
}

But when I try to call an API from methods it's navigating to the route before resolving an API and also NProgress bar is also completing before resolving a call.

{
  beforeRouteEnter(routeTo, routeFrom, next) {
    NProgress.start()
    next((vm) => {
      vm.index()
      NProgress.done()
    })
  },
  methods: {
    index() {
      axios
        .get('https://jsonplaceholder.typicode.com/posts')
        .then((res) => {
          console.log(res.data)
        })
        .catch((error) => {
          console.log(error)
        })
    },
  },
}

Can anyone guide me what may be wrong?

Upvotes: 0

Views: 702

Answers (1)

Gabe
Gabe

Reputation: 2626

In your first example, you set the progress bar, then you call the API with Axios and with .then you chain a function after the call. This means the function will wait until the promise is resolved or rejected, before continuing. Only when the axios call is finished successfully, the next function is executed in which you set the data and stop the progress bar. You also should use .catch for if the promises rejects.

Now in your second example, you do not use promises in beforeRouteEnter. Which basically means that all lines are executed immediately. So you call vm.index() and without waiting for the axios call to finish the next line, NProgress.done() will be executed. Although there are several ways to solve this my preference is use async/await, which is just a cleaner way to use promisses and chaining.

In your case I think this would work:

beforeRouteEnter(routeTo, routeFrom, next) {
  NProgress.start();
  
    await vm.index();
    NProgress.done();
    next();
  });
}

And the method:

methods: {
  async index () {
    try {
      const response = await axios.get('https://jsonplaceholder.typicode.com/posts');
      console.log(response);
    } catch (error) {
      console.log(error);
    }
  }
}

Since this is only a part of your component I cannot test it, but I think you get the idea.

Upvotes: 0

Related Questions