CODEWITHSUNDEEP
githubgithub-codereviews
Barmar
Barmar

Reputation: 781878

Exclude files/directories from code review requirement

Our github repo includes a directory containing language translation files. These are generated automatically from a database. Ideally we should find a way to deploy these through some other mechanism than updating them in our github repository, but that's how it's currently done.

We also have an ads.txt file that we just update with fixed entries whenever our advertising partner sends us new lines. These don't mean anything to us, we just take what they send us.

So whenever these files are updated, we have to go through the process of creating a pull request and reviewing it. I just do a cursory check that it only contains the appropriate files, and then give a pro forma approval.

Is there any way of marking files like these as not requiring code review, so the engineer can just push and merge the changes, and deploy without bothering another engineer for approval?

Upvotes: 2

Views: 2565

Answers (2)

VonC
VonC

Reputation: 1327324

You could create a custom role and assign it to a specific user to a specify user.

If your GitHub Actions identifies as that user, it should then be able to push directly to a protected branch.

Upvotes: 1

jraufeisen
jraufeisen

Reputation: 3877

This is not supported by Github per default. But Github Actions should be powerful enough to handle that requirement. Consider the following pipeline, triggered on each pull request:

  • It performs a git diff to get the list of all files that have been changed. On a quick glance, this github action seems to do that
  • If only files at a specific path or name have been changed, it approves the pull request. Look here for an example action

This should do the trick

Upvotes: 3

Related Questions