CODEWITHSUNDEEP
mysqlhibernate
tusar
tusar

Reputation: 3424

TIMESTAMP column not updating

I am using Struts2, Spring and Hibernate in my application and database is MySQL 5.5. I have this table in database:

create table if not exists campaigns(
    id int(10) not null auto_increment,
    campaignId int(25) not null unique,
    createdBy int(25) not null REFERENCES users(userId),
    campaignName varchar(255) not null,
    subject varchar(500),
    body varchar(50000),
    modifiedOn TIMESTAMP,
    triggeredOn date,
    numberOfTargets int(10),
    primary key (id, campaignId)
);

And I save and update the "Campaign" objects with the following methods (hibernate-mapping through hbm files) :

public boolean addCampaign(long createdBy, String campaignName) throws NoSuchAlgorithmException {
    Campaign campaignObject = new Campaign();
    SecureRandom generatedHash = SecureRandom.getInstance("SHA1PRNG");
    campaignObject.setCampaignId(new Integer(generatedHash.nextInt()));
    campaignObject.setCreatedBy(createdBy);
    campaignObject.setCampaignName(campaignName);
    getHibernateTemplate().save(campaignObject);
    getSession().flush();
    return true;
}

public Date updateCampaign(String campaignId, String subject, String body) throws NumberFormatException {
    Campaign campaign = getCampaignByCampaignId(Long.parseLong(campaignId));
    if(campaign != null) {
        campaign.setSubject(subject);
        campaign.setBody(body);
        getHibernateTemplate().save(campaign);
        getSession().flush();
        return campaign.getModifiedOn();
    }
    return null;
}

The "modifiedOn" column updates when I run a update query on database. But hibernate is failing to update it. Thanks for your time.

Upvotes: 0

Views: 2170

Answers (2)

Xavi López
Xavi López

Reputation: 27880

In addition to JB Nizet's response, if modifiedOn is being updated by a trigger, take a look at org.hibernate.Session#refresh().

In case the field is updated by a trigger, when hibernate saves the entity it has the old date, the trigger udpates the record at DB level (not the hibernate entity), and then when the Session closes, at commit time, Hibernate sees the entity as dirty because the modifiedOn field has a different value in DB. So, another update is launched and it is as if the trigger never updated the field. refresh() will update the entity's state with the one from the DB after the update, and the trigger execution, so they can be in synch at commit time.

public Date updateCampaign(String campaignId, String subject, String body) 
        throws NumberFormatException {
    Campaign campaign = getCampaignByCampaignId(Long.parseLong(campaignId));
    if(campaign != null) {
        campaign.setSubject(subject);
        campaign.setBody(body);
        getHibernateTemplate().update(campaign);
        getSession().flush();
        getSession.refresh(campaign);
        return campaign.getModifiedOn();
    }
return null;
}

Upvotes: 1

JB Nizet
JB Nizet

Reputation: 691775

First of all, save is for inserting a new entity. You should not use it when updating an attached entity. An attached entity's state is automatically written in the database (if changed) at flush time. You don't need to call anything to have the state updated.

And Hibernate won't magically re-read the row it has inserted/updated to get the generated timestamp. A specific @Generated annotation is needed to do that. But it will decrease the performance of the application.

I would use a pre-insert/pre-update hook to set the modifiedOn value programmatically in the entity, and avoid auto-modified timestamps in the database.

Upvotes: 5

Related Questions