CODEWITHSUNDEEP
javajlabel
Hemsho
Hemsho

Reputation: 21

Why is my JLabel being painted twice, however when i minimize and open the frame it's correct?

I have to program a Java-Game for school. I wanted to create a frame in which i briefly explain the mechanics. However, the JLabel that is supposed to do that, is being painted twice. When i close the frame and open it again, it is correctly shown. I really don't why that is.

int panelWidth = 16*16*3 + 300 + 3;
int panelHeight = 16*13*3;
        
JPanel textPanel = new JPanel();
textPanel.setLayout(null);
textPanel.setBounds(0, 0, 2*panelWidth/5, panelHeight);
textPanel.setOpaque(true);
textPanel.setBackground(new Color(0,0,0,0));
        
        JPanel bilderPanel = new JPanel(null){
            /**
             * 
             */
            private static final long serialVersionUID = 1L;

            @Override
            protected void paintComponent(Graphics g) {
                super.paintComponent(g);
                BufferedImage background = null;
                BufferedImage image1 = null;
                BufferedImage image2 = null;
                try {
                    background = ImageIO.read(getClass().getResource("/Screens/ShovelKnightSplash.png"));
                    image1 = ImageIO.read(getClass().getResource("/Screens/ShovelKnightSplash.png"));
                    image2 = ImageIO.read(getClass().getResource("/Screens/ShovelKnightSplash.png"));
                } catch (IOException e) {
                    // TODO Auto-generated catch block
                    e.printStackTrace();
                }
                
                int margin = 15;
                int withPicture =  3*panelWidth/5 - 2*margin;
                int heightPicture = panelHeight /2 - 2*margin;
                
                //g.drawImage(background, -3*panelWidth/5, 0, panelWidth + 300, panelHeight, null);
                
                g.drawImage(image1, margin/2, 0*heightPicture + 1*margin/2, withPicture, heightPicture, null);
                g.drawImage(image2, margin/2, 1*heightPicture + 2*margin/2, withPicture, heightPicture, null);
            }
        };
        bilderPanel.setBounds(2*panelWidth/5, 0, 3*panelWidth/5, panelHeight);
        bilderPanel.setOpaque(true);
        bilderPanel.setBackground(new Color(0,0,0,0));
        //bilderPanel.setBackground(Color.blue);
        
        panel.add(textPanel);
        panel.add(bilderPanel);
        
        JLabel Uberschrift = new JLabel();
        Uberschrift.setText("Das Spiel");
        Uberschrift.setBounds(25, 20, 200, 50);
        Uberschrift.setFont(new Font("Arial", Font.PLAIN, 25));
        
        
        JLabel Controls = new JLabel();
        Controls.setText("<html><body>"
                + "Controls:<br>"
                + "W,A,S,D -> Bewegen<br>"
                + "Leertaste -> Menü Öffnen<br>"
                + "</body></html>");
        Controls.setBounds(25, panelHeight - 250, 2*panelWidth/5 - 50, 150);
        Controls.setFont(new Font("Arial", Font.PLAIN, 18));
        
        JLabel text = new JLabel();
        text.setText("<html><main>"
                + "Die Geschichte spielt in einer offenen Welt, "
                + "doch neben Ruinen gibt es auch mehrere intakte und bewohnte Städte. Die Welt "
                + "umfasst verschiedene Landschaftstypen wie zum Beispiel weite Wiesen, Wälder, "
                + "Berge und Wüsten."
                + "Von Monstern befallen, ist es die Aufgabe von dir"
                + "und deinem Partner die einzelnen Städte zurückzu erobern"
                + ""
                + ""
                + "Es gibt 5 MiniBosse und einen Endboss, welcher sich in der Mitte der Welt befindet"
                + "Man kann ihn bekämpfen, wann man will. Man ist frei in seinem tun."
                + "Allerdings erleichtert es einem das Spielgeschehen, wenn man sich zuvor mit Items aufrüstet"
                + "und LVL sammelt. Für jeden besiegten MiniBoss wird der Endeboss zunehmend geschwächt."
                + "</main></html>");
        text.setBounds(25, 10, 2*panelWidth/5 - 50, 400);
        text.setFont(new Font("Arial", Font.PLAIN, 15));
        
        textPanel.add(Uberschrift);
        textPanel.add(Controls);
        textPanel.add(text);

enter image description here

The images on the right look a little weird, but thats because Im not yet there to replace them with the actual ones.

I wanted to create 3 JLabels:

Because I wanted the Text to break at some Points, I used HTML Code. This may be the problem, but I'm not sure about it and dont know how to start finding the problem.

Upvotes: 1

Views: 40

Answers (1)

MadProgrammer
MadProgrammer

Reputation: 347314

Swing components don't know how to handle alpha based colors (ie new Color(0,0,0,0)), they are either transparent or opaque.

Instead, make use of JComponent#setOpaque.

Don't perform blocking or long running operations in paint methods. Painting should be optimised to run as fast as possible, otherwise your risk making your program unresponsive and/or laggy.

Don't use null layouts, these are just going to continue to cause you issues. Instead, make use of the layout management API instead. See Laying Out Components Within a Container for more details

Runnable example...

enter image description here

import java.awt.Dimension;
import java.awt.EventQueue;
import java.awt.Font;
import java.awt.Graphics;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
import java.awt.Insets;
import java.awt.image.BufferedImage;
import java.io.IOException;
import java.util.logging.Level;
import java.util.logging.Logger;
import javax.imageio.ImageIO;
import javax.swing.JFrame;
import javax.swing.JLabel;
import javax.swing.JPanel;
import javax.swing.JTextArea;

public class Main {
    public static void main(String[] args) {
        new Main();
    }

    public Main() {
        EventQueue.invokeLater(new Runnable() {
            @Override
            public void run() {
                try {
                    JFrame frame = new JFrame();
                    frame.add(new TestPane());
                    frame.pack();
                    frame.setLocationRelativeTo(null);
                    frame.setVisible(true);
                } catch (IOException ex) {
                    Logger.getLogger(Main.class.getName()).log(Level.SEVERE, null, ex);
                }
            }
        });
    }

    public class TestPane extends JPanel {

        public TestPane() throws IOException {
            int panelWidth = 16 * 16 * 3 + 300 + 3;
            int panelHeight = 16 * 13 * 3;

            setLayout(new GridBagLayout());

            JPanel textPanel = new JPanel();
            textPanel.setLayout(new GridBagLayout());
            textPanel.setOpaque(false);

            JPanel bilderPanel = new BackgroundPane();
            bilderPanel.setOpaque(false);

            GridBagConstraints gbc = new GridBagConstraints();
            gbc.gridx = 1;
            gbc.gridy = 0;
            gbc.gridheight = gbc.REMAINDER;
            gbc.weighty = 1;
            gbc.weightx = 1;
            gbc.fill = gbc.BOTH;

            add(bilderPanel, gbc);

            JLabel Uberschrift = new JLabel();
            Uberschrift.setText("Das Spiel");
            Uberschrift.setFont(new Font("Arial", Font.PLAIN, 25));

            JLabel Controls = new JLabel();
            Controls.setText("<html><body>"
                    + "Controls:<br>"
                    + "W,A,S,D -> Bewegen<br>"
                    + "Leertaste -> Menü Öffnen<br>"
                    + "</body></html>");
            Controls.setFont(new Font("Arial", Font.PLAIN, 18));

            JTextArea text = new JTextArea();
            text.setText(
                    "Die Geschichte spielt in einer offenen Welt, \n"
                    + "doch neben Ruinen gibt es auch mehrere intakte und bewohnte Städte. Die Welt \n"
                    + "umfasst verschiedene Landschaftstypen wie zum Beispiel weite Wiesen, Wälder, \n"
                    + "Berge und Wüsten.\n"
                    + "Von Monstern befallen, ist es die Aufgabe von dir\n"
                    + "und deinem Partner die einzelnen Städte zurückzu erobern\n"
                    + "\n"
                    + "\n"
                    + "Es gibt 5 MiniBosse und einen Endboss, welcher sich in der Mitte der Welt befindet\n"
                    + "Man kann ihn bekämpfen, wann man will. Man ist frei in seinem tun.\n"
                    + "Allerdings erleichtert es einem das Spielgeschehen, wenn man sich zuvor mit Items aufrüstet\n"
                    + "und LVL sammelt. Für jeden besiegten MiniBoss wird der Endeboss zunehmend geschwächt.\n");
            text.setFont(new Font("Arial", Font.PLAIN, 15));
            text.setEditable(false);
            text.setFocusable(false);
            text.setOpaque(false);

            gbc = new GridBagConstraints();
            gbc.gridx = 0;
            gbc.gridy = 0;
            add(textPanel, gbc);

            gbc = new GridBagConstraints();
            gbc.anchor = GridBagConstraints.LINE_START;
            gbc.gridx = 0;
            gbc.gridy = 0;
            gbc.insets = new Insets(32, 32, 16, 32);
            textPanel.add(Uberschrift, gbc);

            gbc.gridy = 1;
            gbc.insets = new Insets(16, 32, 16, 32);
            textPanel.add(text, gbc);

            gbc.gridy = 2;
            gbc.insets = new Insets(16, 32, 32, 32);
            textPanel.add(Controls, gbc);

        }

        protected class BackgroundPane extends JPanel {
            private BufferedImage background = null;
            private BufferedImage image1 = null;
            private BufferedImage image2 = null;

            public BackgroundPane() throws IOException {
                background = ImageIO.read(getClass().getResource("/images/Mando01.jpeg"));
                image1 = background;
                image2 = background;
            }

            @Override
            public Dimension getPreferredSize() {
                int panelWidth = 16 * 16 * 3 + 300 + 3;
                int panelHeight = 16 * 13 * 3;
                return new Dimension(panelWidth, panelHeight);
            }

            @Override
            protected void paintComponent(Graphics g) {
                super.paintComponent(g);

                System.out.println(getPreferredSize());

                int margin = 15;
                int withPicture = 3 * getWidth() / 5 - 2 * margin;
                int heightPicture = getHeight() / 2 - 2 * margin;

                g.drawImage(background, -3 * getWidth() / 5, 0, getWidth() + 300, getHeight(), this);
                g.drawImage(image1, margin / 2, 0 * heightPicture + 1 * margin / 2, withPicture, heightPicture, this);
                g.drawImage(image2, margin / 2, 1 * heightPicture + 2 * margin / 2, withPicture, heightPicture, this);
            }

        }

    }
}

Upvotes: 1

Related Questions