CODEWITHSUNDEEP
objective-cios
Arsynth
Arsynth

Reputation: 793

Memory leaks warnings

I have a viewcontroller, into this I add a several subviews to his view, add in array(array - its property of parent viewcontroller) and didn't release subviews to add now, but release their in dealloc. I am embarrassed by messages about memory leaks. How can I find any way to solve problem with memory management? Thanks!

-(void)someMethod
{
    for(<<something in something>>)
    {
            ValidationColumnViewController *controller = [[ValidationColumnViewController alloc] initWithFrame:CGRectMake(columnsInitialX, 5, validationColumnWidth, validationColumnHeight) andValidationColumn:column withMaxCellsCount:maxCellsCountForValidationColumns];               
            [gameFieldView addSubview:controller.view];
            [validationColumnViewControllers addObject:controller];
    }
}
-(void)dealloc
{
    for(ValidationColumnViewController *controller in validationColumnViewControllers)
    {
        [controller release];
    }
}

Upvotes: 0

Views: 114

Answers (3)

morningstar
morningstar

Reputation: 9122

I think that your code will actually work fine, though the recommendations in the other answers are better coding practice and style. You are not getting the advantages of reference counting your way.

The compiler is unable to figure out that your code guarantees the objects in the array will be released. It looks for simple patterns like releasing in the same scope as creating, or retaining instance variables and releasing them in dealloc. If it can't find them, it gives a warning, but that does not necessarily mean you are managing memory wrong, just that the compiler cannot verify that you are doing it right. Doing something outside the patterns the compiler recognizes should rarely be necessary though.

Upvotes: 0

jbat100
jbat100

Reputation: 16827

You should definitely release the objects you create with the line

ValidationColumnViewController *controller = [[ValidationColumnViewController alloc] initWithFrame:CGRectMake(columnsInitialX, 5, validationColumnWidth, validationColumnHeight) andValidationColumn:column withMaxCellsCount:maxCellsCountForValidationColumns];

Just after you add them to the array (the addObject: call increases the object's retain count by 1), not in the dealloc. If you don't they might be removed from the array before the dealloc by some other call and in that case, you'll leak memory. I think you should also release validationColumnViewControllers in the dealloc method given it is apparently a retained ivar.

Also adding the controller.view object to another view:

[gameFieldView addSubview:controller.view];

is not a good idea, this increases the controller.view retain count by 1 but not the controller retain count. This means the controller could be deallocated but not its view which will lead to problems (EXEC_BAD_ACCESS when the view tries to talk to its controller).

Also in 

-(void)dealloc

you should always call [super dealloc] at the end of the function, this is what actually causes the object to be deallocated.

Upvotes: 1

Graham Perks
Graham Perks

Reputation: 23390

Release each one immediately after the addObject call. No need to wait for dealloc.

Upvotes: 4

Related Questions