CODEWITHSUNDEEP
java
user979490
user979490

Reputation: 280

Implementing the equals method in java

This is my implementation of the equals class for a Coor class which is just contains 2 ints x and y. would this be the proper way of implementing this method?

 public boolean equals(Object obj) {
        if (obj == null || obj.getClass() != this.getClass()) {
            return false;
        }
        Coor temp = (Coor) obj;
        if (temp.x == this.x && temp.y == this.y) {
            return true;
        } else {
            return false;
        }
    }

Upvotes: 5

Views: 1212

Answers (7)

duffymo
duffymo

Reputation: 308763

There's only one source to read for how to override equals and hashCode: chapter 3 of Joshua Bloch's "Effective Java".

If you have a good IDE, like IntelliJ, it'll generate equals and hashCode the right way for you.

Upvotes: 0

Pat
Pat

Reputation: 25675

You could add one more check for reflexive equality (equal to self):

 public boolean equals(Object obj) {

    // Reflexive equality: did I get passed myself?
    if(this == obj){
        return true;
    }

    if (obj == null || obj.getClass() != this.getClass()) {
        return false;
    }

    Coor temp = (Coor) obj;
    return temp.x == this.x && temp.y == this.y;
}

Upvotes: 7

pseudoramble
pseudoramble

Reputation: 2561

I believe this would work, at a quick glance. I say this because:

  1. It handles a null/improper types well.
  2. Performing x.equals(y) would yield the same result as y.equals(x).
  3. Performing x.equals(x) would return true.
  4. Performing x.equals(y) == true and y.equals(z) == true implies that x.equals(z) == true

This question has certainly been asked many times before though. See here: Overriding equals and hashCode in Java. A book called Effective Java discusses this topic in great detail too, and the particular chapter is linked off of there.

Upvotes: 0

Daniel Brockman
Daniel Brockman

Reputation: 19270

Here’s a more straightforward way:

public boolean equals(Object other) {
    return other instanceof Coor
      && ((Coor) other).x == x
      && ((Coor) other).y == y
}

Upvotes: 0

user470714
user470714

Reputation: 2888

Check this out:

http://www.javapractices.com/topic/TopicAction.do?Id=17

If that article is too much detail, then the short of it is: Your implementation is correct, but you should keep some other things in mind:

  1. You will also have to implement hashCode.

  2. equals will no longer commpare the object's identity. Doesn't sound like that's a problem for you.

  3. You could add the @Override annotation to your equals method.

Upvotes: 1

pcalcao
pcalcao

Reputation: 15990

Seems ok. For brevity sake, you can do:

return temp.x == this.x && temp.y == this.y

Instead of 

if (temp.x == this.x && temp.y == this.y) {
        return true;
    } else {
        return false;
    }

Also, please keep in mind the Object Contract (seriously!).

See the accepted answer here: What issues should be considered when overriding equals and hashCode in Java?

This can save you a huge about of headache in the future.

Upvotes: 3

Bill K
Bill K

Reputation: 62769

Yes, it would.

Also be sure to override your hashCode() method--never override one without doing the other as well, it will confuse the hell out of your collections.

Your case could use a hash where it simply shifts one of the ints 32 bits and adds it to the other creating a completely unique long (a perfect hash function in this case--no collisions)

Upvotes: 5

Related Questions