CODEWITHSUNDEEP
javagrpcgrpc-javaprotobuf-javaproto3
Jeevi
Jeevi

Reputation: 3042

Do we have Future Datatype in Protobuf

I am exploring on grpc

My sample application fetches few records from Database + reads a file from S3(very small file) and returns the combined result.

Since the file size is very less, i am not using streams.

So, the service layer of my application will return a CompletableFuture

 CompletableFuture<Book> getContent(String bookId);

My Grpc ServiceBaseImpl will have the below code.

  public void getBook(GetBookrequest request, StreamObserver<Book> responseObserver){
    CompletableFuture<Book> bookContentFuture = bookService.getContent(request.getBookId());
    Book book = bookContentFuture.get() ; // blocking 
    responseObserver.onNext(book);
    responseObserver.onCompleted();
}

Here i am making a blocking get call and waiting for the result before send the response back.

In Rest Application , i can have a controller which can return the CompletableFuture<Book>

Is it possible to return a Future in GRPC . I don`t find any future type in protobuf , it means its okay to block before responding?

Upvotes: 0

Views: 108

Answers (2)

Louis Wasserman
Louis Wasserman

Reputation: 198471

It sounds like you're just looking for the future stub or asynchronous stub.

Upvotes: 0

Alex Gordon
Alex Gordon

Reputation: 60871

generally not recommended to block and wait for CompletableFuture .

if you have a small file size and dont want to use streaming, you can theoretically blcok and wait for CompletableFuture before sending the response back.

you can still return CompletableFuture from the service method.

something like this

import io.grpc.stub.StreamObserver;
import io.grpc.Status;
import io.grpc.StatusRuntimeException;
import com.google.common.util.concurrent.MoreExecutors;
import io.grpc.stub.ServerCallStreamObserver;

public void getBook(GetBookRequest request, StreamObserver<Book> responseObserver) {
  CompletableFuture<Book> bookContentFuture = bookService.getContent(request.getBookId());

  bookContentFuture.whenCompleteAsync((book, throwable) -> {
    if (throwable != null) {
      StatusRuntimeException exception = Status.INTERNAL
          .withDescription("Error retrieving book content")
          .withCause(throwable)
          .asRuntimeException();
      responseObserver.onError(exception);
    } else {
      responseObserver.onNext(book);
      responseObserver.onCompleted();
    }
  }, MoreExecutors.directExecutor());
}

Upvotes: 0

Related Questions