CODEWITHSUNDEEP
c#.net
Alessandro
Alessandro

Reputation: 3761

Optional parameters "must be a compile-time constant"

I have a class divided in two partial files, like this:

public partial class PersonRepository : BaseRepository<Person>
{
    public static readonly string ColumnID = "ID";
    ...

and

public partial class PersonRepository : BaseRepository<Person>
{
    public List<Person> GetByCompany(int companyID, string sortExpression = ColumnID)
    {
    ...

But the compiler keeps saying that sortExpression "must be a compile-time constant". To me it seems a perfect compile-time constant, so I don't understand where the problem is.

Upvotes: 60

Views: 61656

Answers (8)

Żubr&#243;wka
Żubr&#243;wka

Reputation: 720

Try to change this

public static readonly string ColumnID = "ID";

to

public const string ColumnID = "ID";

Upvotes: 4

Ben
Ben

Reputation: 113

Just for completeness, here are the three valid default values for an optional argument: ( from: MSDN: Named and Optional Arguments)

  1. a constant expression
  2. an expression of the form new ValType(), where ValType is a value type, such as an enum or a struct; (note: only the parameterless constructor can be used)
  3. an expression of the form default(ValType), where ValType is a value type.

Upvotes: 3

AakashM
AakashM

Reputation: 63338

readonly

The value of a readonly field can be changed (in a constructor). You need a const.

Upvotes: 5

archil
archil

Reputation: 39501

public const string ColumnID = "ID";

Upvotes: 2

&#216;yvind Br&#229;then
&#216;yvind Br&#229;then

Reputation: 60694

change

public static readonly string ColumnID = "ID";

to

public const string ColumnID = "ID";

Upvotes: 5

Jon Skeet
Jon Skeet

Reputation: 1500525

No, the expression PersonRespository.ColumnID is not classified as a compile-time constant. The expression "ID" is, but that's not what you're using as the default parameter.

In particular, if ColumnID is "just a normal field" then any references to it will be resolved as a field - so if you compile an assembly which refers to the field, then change the value and rebuild the assembly containing PersonRepository, the referring assembly will see that change.

If you change your declaration to:

 public const string ColumnID = "ID";

then it is a compile-time constant expression. That means in our previous scenario, the value of the constant is baked into any code that refers to it - and changing the value later without recompiling that referring code won't change the value used by that referring code.

See section 7.19 of the C# 4 language specification for more details about what counts as a constant expression.

Upvotes: 61

Muhammad Hasan Khan
Muhammad Hasan Khan

Reputation: 35126

const is something declared with const keyword.

readonly field can be assigned in constructor and its not compile time constant. the code that you've written right now runs in initializer (before constructor). const fields are 'baked' in as constants.

Upvotes: 5

Paolo Tedesco
Paolo Tedesco

Reputation: 57202

You must declare your ColumnID as const.

The static readonly string will be instantiated when the class is first accessed in your code, and you could also initialize it with the return value of a static method, so it's not a compile-time constant for the compiler (even if in this case it obviously is for a person reading the code).

Upvotes: 7

Related Questions