CODEWITHSUNDEEP
jquerygoogle-chromewebkit
PeeHaa
PeeHaa

Reputation: 72709

WebKit issues with event.layerX and event.layerY

I just noticed that I get tons of deprecated warnings in the latest (canary) build of Chrome.

event.layerX and event.layerY are broken and deprecated in WebKit. They will be removed from the engine in the near future.

Looks like jQuery is screwing thing up.

I'm using: jquery-1.6.1.min.js.

Would it help to upgrade to the latest jQuery version or isn't it fixed yet or is it a Chrome bug or is it something else.

PS

I cannot show you code because I think it's a general error, but I suspect the warnings get thrown when I try to access a jQuery object or when jQuery tries to access the layerX / layerY (well I'm pretty sure that's the case considering the error :P).

jQuery probably copies those properties into the jQuery object.

So...

What's going on?

EDIT

jQuery 1.7 is out and fixes this issue.

Read more at their blog, here.

Upvotes: 511

Views: 97044

Answers (9)

mekwall
mekwall

Reputation: 28974

The shortest solution to this is this one-liner:

$.event.props = $.event.props.join('|').replace('layerX|layerY|', '').split('|');

Upvotes: 28

Juan Carlos Arevalo
Juan Carlos Arevalo

Reputation: 181

I've used this after calling any event:

$.event.props.splice($.event.props.indexOf("layerY"),1);
$.event.props.splice($.event.props.indexOf("layerX"),1);

That worked for me, I have no warning messages since I've made this patch on my code.

Upvotes: 5

Jake
Jake

Reputation: 558

It can also be caused by Chrome extensions, so check them if the jQuery update doesn't work.

Upvotes: 14

David Murdoch
David Murdoch

Reputation: 89402

http://jsperf.com/removing-event-props/2

The temporary fix is to run this code before you do any event binding via jQuery:

(function(){
    // remove layerX and layerY
    var all = $.event.props,
        len = all.length,
        res = [];
    while (len--) {
      var el = all[len];
      if (el != 'layerX' && el != 'layerY') res.push(el);
    }
    $.event.props = res;
}());

UPDATE

See the latest performance tests to find out what the fastest way is to remove the event props.

Upvotes: 74

Kris Giesing
Kris Giesing

Reputation: 334

I ran into this issue in my own code. It turns out I was iterating over all properties on an event object as part of a debugging/inspection tool that I was using. In this particular instance I was using jQuery's $.extend to clone the object for later inspection, but I believe any of the standard iteration techniques in the various toolkits would have triggered the warning as well.

I mention it here because my initial thought of simply searching the code base for instances of layerX or layerY didn't help - the property was being referenced generically, not by name.

Upvotes: 3

DUzun
DUzun

Reputation: 1722

Here is another one line fix, without replacing the original instance of $.event.props (which may or may not be an array), just in case :-)

$.each(["layerX","layerY"], function(i,v) { if((i=p.indexOf(v)) > -1) $.fn.splice.call($.event.props,i,1) })

Upvotes: 5

xgretsch
xgretsch

Reputation: 1443

As well as the configuration issues listed in the other answers, this error can be triggered by a simple error in your own code: forgetting the '#' in from of a jQuery ID selector.

I had code looking like

$('datenotset_2341').click(function(){
 ....etc....
});

(missing out the # in front of the "datenotset")

As well as (obviously) failing to work, it triggered this error message in Chrome.

Upvotes: 4

Adam A
Adam A

Reputation: 14630

What's going on!?

"jQuery probably copies those properties into the jQuery object." You're exactly correct, so it sounds like you already know! :)

Hopefully jQuery will update their code to stop touching that, but at the same time WebKit should have known better than to log a deprecation warning on an event (at least in my opinion). One mousemove handler and your console explodes. :)

Here's a recent jQuery ticket: http://bugs.jquery.com/ticket/10531

UPDATE: This is fixed now if you upgrade to jQuery 1.7.

Please note that if upgrading jQuery doesn't fix the issue for you it may have something to do with used extensions / plugins as Jake stated in his answer.

Upvotes: 464

törzsmókus
törzsmókus

Reputation: 2001

The enormous amount of these messages (I just got 80000 of them while using gmail) is indeed a bug in Chrome.

You should star the issue on Chromium.

Upvotes: 21

Related Questions