Parth Doshi
Parth Doshi

Reputation: 4208

Exception causing VB.NET code to not run properly

I am getting an exception when I run the below VB.NET code to validate a user..The exception says that "Incorrect syntax near variable user"

Can anyone tell me where am I going wrong ?

      Private Sub Button1_Click(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles Button1.Click

    If TextBox1.Text.Trim().Length = 0 Or TextBox2.Text.Trim().Length = 0 Then
        MsgBox("Enter a user id and password")
        Return 'Terminate this method
    End If

    Dim myconnection As SqlConnection
    Dim mycommand As SqlCommand
    Dim dr As SqlDataReader
    Dim userid = TextBox1.Text
    Dim password = TextBox2.Text

    Try
        myconnection = New SqlConnection("server=PARTH- PC\SQLEXPRESS;uid=sa;pwd=parth;database=fcrit")

        myconnection.Open()
        mycommand = New SqlCommand("select * from user where [user id]=@userid and [password]=@password", myconnection)
        mycommand.Parameters.Add("@userid", SqlDbType.VarChar, 30).Value = userid
        mycommand.Parameters.Add("@password", SqlDbType.VarChar, 30).Value = password

        'mycommand = New SqlCommand("select * from user where user id='" & TextBox1.Text & "' and password='" & TextBox2.Text & "'", myconnection)
        dr = mycommand.ExecuteReader()

        If (dr IsNot Nothing) Then
            If (dr.Read()) Then
                MsgBox("User is authenticated")
                Form2.Show()
            Else
                MsgBox("Please enter correct username and password")
            End If
        End If
        myconnection.Close()
    Catch ex As Exception
        Throw

    Finally
    End Try
  End Sub

Upvotes: 1

Views: 201

Answers (2)

Guffa
Guffa

Reputation: 700432

User is a reserved word in SQL Server.

Put brackets around the table name:

mycommand = New SqlCommand("select * from [user] where [user id]=@userid and [password]=@password", myconnection)

Upvotes: 2

ipr101
ipr101

Reputation: 24236

Try changing your SQL to -

"select * from [user] where [user id]=@userid and [password]=@password"

According to this page 'User' is a reserved word

Upvotes: 3

Related Questions