CODEWITHSUNDEEP
ruby-on-railsruby-on-rails-3actionmailer
Gaelle
Gaelle

Reputation: 599

ActionMailer fails

I get a no method error when trying to send out email with ActionMailer

NoMethodError in OrdersController#deliver
undefined method `client' for #<OrdersController:0x007fdc22aa4938>

My Mailer

 class OrdersMailer < ActionMailer::Base
 def email_copy_of_order_to_client(order)
    @order = order
    @client = @order.client
    mail(:to => @client.email, :subject => "Your order")
  end

Of course through the console I get what I want

  Order.last.client
    Order Load (0.2ms)  SELECT "orders".* FROM "orders" ORDER BY "orders"."id" DESC LIMIT 1
  => #<Client id: 3, name: "Test Client", address1: "", address2: "", city: ""...`

EDITED

class OrdersController < InheritedResources::Base
def deliver
@email = OrdersMailer.email_copy_of_order_to_client(self).deliver

respond_to do |format|
  if @email.valid?
    format.html { redirect_to order, notice: 'Order was successfully sent.' }
  else
    format.html { render action: "show", alert: 'An error occured. Please try again.' }
  end
end
end

Order#show view

<%= pill_button_link_to "Send Order by Email", deliver_order_path(@order) %>

Any idea?

Upvotes: 0

Views: 503

Answers (1)

mu is too short
mu is too short

Reputation: 434575

Your mailer wants an Order as its argument:

class OrdersMailer < ActionMailer::Base
  def email_copy_of_order_to_client(order)
    #...

but you're giving it an instance of OrderController:

class OrdersController < InheritedResources::Base
  def deliver
    @email = OrdersMailer.email_copy_of_order_to_client(self).deliver
    #...

That self is an instance of the controller, not an instance of Order. Hence your error message about OrdersController:

undefined method `client' for #<OrdersController:0x007fdc22aa4938>

You probably want something like this in your deliver:

def deliver
  order = Order.find(params[:id])
  # check access/ownership/... on order
  @email = OrdersMailer.email_copy_of_order_to_client(order).deliver
  #...

Upvotes: 1

Related Questions