CODEWITHSUNDEEP
salesforceapexapex-codesoqlapex-trigger
Kavya
Kavya

Reputation: 3

Too many SOQL queries: 101

I have a trigger which runs i will share a piece of code which is affecting the functionality

for(Pos_Item__c posItem:[SELECT Id,InProcess_Inventory_Stock__c FROM Pos_Item__c WHERE Id IN :posItemsWithInprocessInventory.keySet()])
            {
                if(posItem.InProcess_Inventory_Stock__c==null)
                posItem.InProcess_Inventory_Stock__c=0;
                posItem.InProcess_Inventory_Stock__c-=posItemsWithInprocessInventory.get(posItem.Id);
                posItems.add(posItem);
            }

I tried querying outside the for loop

List<Pos_Item__c> posItemsList = [SELECT Id, InProcess_Inventory_Stock__c FROM Pos_Item__c WHERE Id IN :posItemsWithInprocessInventory.keySet()];
            for(Pos_Item__c posItem:posItemsList)
            {
                if(posItem.InProcess_Inventory_Stock__c==null)
                posItem.InProcess_Inventory_Stock__c=0;
                posItem.InProcess_Inventory_Stock__c-=posItemsWithInprocessInventory.get(posItem.Id);
                posItems.add(posItem);
            }

But still the same issue please help me understand how to overcome this issue

If i comment this piece of code everything is working fine.
But this part is very important

Thanks in advance

Tried using Map and List as well

Upvotes: 0

Views: 153

Answers (1)

eyescream
eyescream

Reputation: 19612

The code you posted looks good, the for(Pos_Item__c posItem:[SELECT syntax is legit. I think you have something outside this, another loop that calls this one over 100 times. Examine the debug log of your failed action, check if this SELECT... appears in the log over and over... Or post a bigger snippet of the code?

There are static analysis tools like PMD or salesforce code scanner that might help identifying the loop.

There's also chance you have recursion here (before update trigger, updates something on "this" record, calls same trigger...), sometimes these are bit sneaky if you have trigger + flow for example.

If there's no outer loop in this trigger / trigger handler itself... Generally what's the outer code? This looks like some "mass reduce quantity on purchase order lines" - how is this called? 1 bulk update lineItems; or an update statement in a loop?

Upvotes: 1

Related Questions