Linq to XML: query returning same result 3 times instead of 3 results

Question

There are 3 deposits in my XML file, but the query is only returning the first deposit 3 thime. I have pastd in the Customer class and the XML file. This is a .Net 4 windows forms application. Deposits are shown on the form when the user clicks a 'DEPOSITS' button.

User Inerface form method that calls Customer Class:

    private void btnDeposits_Click(object sender, EventArgs e)
    {
        if (customerId == "0")
        {
            MessageBox.Show("Please first select a customer", "Error");
            return;
        }

        BL_Customer oCustomer = new BL_Customer();

        try
        {
            //Call method to pull data from XML
            oCustomer.getDeposits(customerId);
        }
        catch (Exception ex)
        {
            tssErrors.Text = ex.Message;
        }

        //Set datagridview datasource and format the view Headers & Cells
        dgvDeposits.DataSource = oCustomer.Deposits;
        dgvDeposits.Columns[0].HeaderText = "Deposit ID";
        dgvDeposits.Columns[1].HeaderText = "Amount";
        dgvDeposits.Columns[2].HeaderText = "Date of Deposit"; 
        dgvDeposits.Columns[0].HeaderCell.Style.Alignment = DataGridViewContentAlignment.MiddleCenter;
        dgvDeposits.Columns[1].HeaderCell.Style.Alignment = DataGridViewContentAlignment.MiddleCenter;
        dgvDeposits.Columns[2].HeaderCell.Style.Alignment = DataGridViewContentAlignment.MiddleCenter;
        dgvDeposits.Columns[0].DefaultCellStyle.Alignment = DataGridViewContentAlignment.MiddleLeft;
        dgvDeposits.Columns[1].DefaultCellStyle.Alignment = DataGridViewContentAlignment.MiddleRight;
        dgvDeposits.Columns[2].DefaultCellStyle.Alignment = DataGridViewContentAlignment.MiddleLeft;
        dgvDeposits.Columns[1].DefaultCellStyle.Format = "c2";
        dgvDeposits.Columns[0].Width = 50;
        dgvDeposits.Columns[1].Width = 60;
        dgvDeposits.Columns[2].Width = 80;
    }

CUSTOMER class

   public BL_Customer()
    {
        oDeposits = new List();
    }

    public List addDeposits(BL_Deposit oDeposit)
    {
        oDeposits.Add(oDeposit);
        return oDeposits;
    }

   public double  getDeposits(string customerId)
    {
        double sumDep = 0;
        //Returns list of deposits for selected customer
        var doc = XDocument.Load("Portfolio.xml");
        var Deposits = from account in doc.Descendants("account")
                       from deposit in account.Elements("deposits")
                       where (string)account.Element("acct").Attribute("custid").Value == customerId
                       select new
                       {
                           Depid = (string)deposit.Attribute("depid").Value,
                           Amount = (string)deposit.Attribute("depamount").Value,
                           Date = (string)deposit.Attribute("depdate").Value
                       };

                        //Loop through deposits and add a deposit object
                        BL_Deposit oDeposit = new BL_Deposit();
                        for (int i = 0; i < 3; i++)
                        {
                            oDeposit.DepAmt = Convert.ToDouble(Deposits.ElementAt(i).Amount);
                            oDeposit.DepDate = Convert.ToDateTime(Deposits.ElementAt(i).Date);
                            oDeposit.DepositId = Convert.ToInt32(Deposits.ElementAt(i).Depid);
                            addDeposits(oDeposit);
                            sumDep += oDeposit.DepAmt;
                        }
                        return sumDep;
        }

XML File

Martin Honnen · Accepted Answer

Well you create a single object with BL_Deposit oDeposit = new BL_Deposit();, then in your loop you change the properties of the same object. Move the code with the creation of the object into the loop, then I think you should get what you want.

Of course you could create the objects directly in the query, avoiding the anonymous objects.

[edit] Here is how you can use LINQ to directly create your List:

List deposits =
  (from account in doc.Descendants("account")
from deposit in account.Elements("deposits")
where (string)account.Element("acct").Attribute("custid").Value == customerId
select new BL_Deposit() 
{
    DepositId = (int)deposit.Attribute("depid"),
    DepAmt = (double)deposit.Attribute("depamount"),
    DepDate = Convert.ToDateTime(deposit.Attribute("depdate").Value)
}).ToList();

Then you can also compute the sum with e.g. sumDep = deposits.Sum(d => d.DepAmt);.

Linq to XML: query returning same result 3 times instead of 3 results

Answers (1)

Related Questions