CODEWITHSUNDEEP
c#arrays
okr
okr

Reputation: 135

Displaying Array within Method

This relates to another code I posted earlier but since this is a different question I decided to make a new post. I'm currently stuck with this code, I'm a c# beginner so this look complicated to me. I've been working on this code that is supposed to get an array from the user, calculate its average then display the results inside show(). I got this working to show the average of the array but now I need to actually display the array each value individually i.e. The 1st value you entered was : 12 The 2nd value you enteres was : 32

Thank guys!

        private static int Array()
        {
            string inValue;
            int[] score = new int[10];
            int total = 0;

            for (int i = 0; i < score.Length; i++)
            {
                Console.Write("Enter Value {0}: ", i + 1);
                inValue = Console.ReadLine();
                score[i] = Convert.ToInt32(inValue);
            }

            for (int i = 0; i < score.Length; i++)
            {
                total += score[i];   
            }
            return total;
        }

Upvotes: 2

Views: 2074

Answers (3)

Icarus
Icarus

Reputation: 63956

Move int[] score out of GetValues and declare it at the class level making it static:

 static int[] score = new int[5];

My next recommendation is that you don't do inside your functions more than what they claim to do from their name; for example, GetValues() should only get the values from user; not calculate totals (as you are doing) because it's misleading; it forces you to look at the implementation to know exactly what it does. Similarly for Show(); if the purpose is to show values entered by user, then call it ShowValues(); If the purpose is to show values entered by user as well as calculate the average, then name it something along the lines of ShowValuesAndAverage()

Here's a complete implementation of your program with my recommendations:

using System;
using System.Collections.Generic;
using System.Linq;
using System.Text;

namespace testscores
{
    class Program
    {
        static int[] score = new int[5];
        //Get Values     
        private static void GetValues()
        {
            string inValue;

            for (int i = 0; i < score.Length; i++)
            {
                Console.Write("Enter Value {0}: ", i + 1);
                inValue = Console.ReadLine();
                score[i] = Convert.ToInt32(inValue);
            }

        }

        //FIND AVERAGE
        private static double FindAverage()
        {
            double total = 0.0;
            for (int i = 0; i < score.Length; i++)
            {
                total += score[i];
            }
            double average = total / 5.0;
            return average;
        }

        //Show
        static void ShowValuesAndAverage()
        {
            Console.WriteLine("The values are:");
            for (int i = 0; i < score.Length; i++)
            {
                Console.WriteLine(string.Format("The {0} value you entered was {1}", i + 1, score[i]));
            }
            Console.WriteLine("The average is: {0}", FindAverage());
        }
        //Main
        static void Main()
        {
            GetValues();
            ShowValuesAndAverage(); 
            Console.ReadKey();
        }
    }
}

Upvotes: 1

GregL
GregL

Reputation: 38113

Change your GetValues() function to actually return the array of integers, then use the return value in your other functions.

i.e. change GetValues() to:

    private static int[] GetValues()
    {
        string inValue;
        int[] score = new int[5];
        int total = 0;

        for (int i = 0; i < score.Length; i++)
        {
            Console.Write("Enter Value {0}: ", i + 1);
            inValue = Console.ReadLine();
            score[i] = Convert.ToInt32(inValue);
        }

        return score;
    }

EDIT: Here is how to use the GetValues() function above in a function to print out all the values. You should be able to work out the rest from here:

private static void PrintArray(int[] scoreArray)
{
    for (int i = 0; i < scoreArray.Length; i++)
    {
         Console.WriteLine("Value #{0}: {1}", i + 1, scoreArray[i]);
    }
}

Note how the scoreArray is passed in, as well as how each value is accessed, using scoreArray[i] (where i is a number from 0 to 4 inclusive).

Upvotes: 2

John Smith
John Smith

Reputation: 28

Make one function for GetValues() and return the array. Then pass the array into a AddValues() function, and into Show(). Either that or read up on how to use pointers, but that might be overcomplicating things a little.

Upvotes: 0

Related Questions