CODEWITHSUNDEEP
phpcodeigniter
spotlightsnap
spotlightsnap

Reputation: 1113

Code Igniter Count Function

What I want to do is I want to count the total records from the table called "songs_tbl" from my database. So I wrote this function in controller.

private function getHeaderInfo()
{
         $total_songs = $songs->count('distinct songs_tbl.song_id');
         $this->mysmarty->assign('total_songs',$total_songs);
}

I got this error

Fatal error: Call to a member function count() on a non-object in

Any suggestion ? Thank you.

With Regards,

Upvotes: 1

Views: 13978

Answers (4)

tinhphaistc
tinhphaistc

Reputation: 35

you can use this

$query = $this->db->get('distinct');
        if($query->num_rows())
        {
            return $query->num_rows();
        }else{
            return 0;
        }

Upvotes: 0

Cubed Eye
Cubed Eye

Reputation: 5631

I think you are looking for:

$this->db->count_all('songs_tbl');

or if you want the distinct in there you will need to do something like this:

$this->db->select('song_id');
$this->db->distinct();
$this->db->from('songs_tbl');
$query = $this->db->get();
return $query->num_rows();

As there is/was? an issue with using count_all_results() function and DISTINCT

EDIT

I have never used smarty but based on the code in the question I imagine something like this might work, please correct me if I am wrong:

private function getHeaderInfo()
{
    $total_songs = get_all_songs();// This function should be called through a model
    $this->mysmarty->assign('total_songs',$total_songs);
}

function get_all_songs(){ //THIS SHOULD BE IN A MODEL
    $this->db->select('song_id');
    $this->db->distinct();
    $this->db->from('songs_tbl');
    $query = $this->db->get();
    return $query->num_rows();
}

Edit 2

My suggested layout would be something along these lines (UNTESTED) using CodeIgniter WITHOUT smarty:

Model Song.php

class Song extends CI_Model {
    //Constructor and other functions

    function count_all_songs(){
        $this->db->select('song_id');
        $this->db->distinct();
        $this->db->from('songs_tbl');
        $query = $this->db->get();
        return $query->num_rows();
    }
}

Controller Songs.php

class Song extends CI_Controller {
    //Constructor and other functions

    function index(){ //This could be any page
        $this->load->model('Song'); //Could be in constructor
        $total_songs = $this->Song->count_all_songs();
        $this->load->view('songs_index.html', array('total_songs' => $total_songs));
    }
}

View songs_index.html

<html><head></head><body>
    Total Songs: <?php echo $total_songs ?>
</body></html>

Upvotes: 5

Rohan Patil
Rohan Patil

Reputation: 2348

Try this

echo $this->db->count_all('songs_tbl');

It permits you to determine the number of rows in a particular table.

Upvotes: 1

Ayush
Ayush

Reputation: 42450

You could query the table and request a count from the table itself, like this:

$result = mysql_query(SELECT count(*) FROM songs_tbl);

Upvotes: 1

Related Questions