CODEWITHSUNDEEP
javasockets
Rooster
Rooster

Reputation: 1277

Setting socket local port throws exception

Given this:

. . .
ServerSocket serverSocket = new ServerSocket(1111);

while (helperSockets.size() < Common.NUM_HELPERS) {
    Socket helperSocket = serverSocket.accept();
. . .

This throws the exception:

new Socket("localhost", 1111, InetAddress.getLocalHost(), localPort);

Exception:

java.net.ConnectException: connect: Address is invalid on local machine, or port is not valid on remote machine

I'm trying to use this constructor to set the local port, so what am I doing wrong? Source below.

The constructor creates a thread that listens for clients via ServerSockets, while trying to connect to other clients. This client tries to connect with itself for testing. The problem is encountered upon first iteration of the for loop.

public class DisSemHelper extends Thread {
private int id;
private int semaphore;
private Clock clock;
private Vector<Socket> helperSockets;
private int localPort;

private int receivedSender;
private String receivedOperation;
private int receivedTimestamp;

/**
 */
public DisSemHelper(int id) {
    this.id = id;
    this.semaphore = 0;
    this.clock = new Clock();
    this.helperSockets = new Vector<Socket>();
    this.receivedSender = -1;
    this.receivedOperation = null;
    this.receivedTimestamp = -1;
    this.localPort = Common.portMap.get(id);

    new ConnectionListener().start();

    /* Create and store connections to all helpers */
    for (int i=0; helperSockets.size() < Common.NUM_HELPERS; i++) {
        Socket helperSocket = null;
        //              String portKey = "STREET_" + i;

        /* Wait until target street socket is ready. Retry every second. */
        Exception e = new ConnectException();
        while (helperSocket == null) {
            try {
                Thread.sleep(1000);
                helperSocket = new Socket("localhost", 2222, InetAddress.getLocalHost(), localPort);

            } catch (ConnectException ce) {
                e = ce;
                e.printStackTrace();
            } catch (UnknownHostException uhe) {
                uhe.printStackTrace();
            } catch (IOException ioe) {
                ioe.printStackTrace();
            } catch (InterruptedException ie) {
                e.printStackTrace();
            }
        }

        int remotePort = helperSocket.getPort();
        int connectedHelperID = Common.portMap.indexOf(remotePort);
        if (this.helperSockets.size() <= connectedHelperID) {
            this.helperSockets.add(helperSocket);
            System.out.println("Helper " + id + " added socket from outgoing: local port: " + helperSocket.getLocalPort() + " remote port: " + helperSocket.getPort());
        }
    }

    System.out.println(this.helperSockets);
}

private class ConnectionListener extends Thread {
    public void run() {
        try {
            ServerSocket serverSocket = new ServerSocket(2222);

            /* Listen for connections from other helpers */
            while (helperSockets.size() < Common.NUM_HELPERS) {
                Socket helperSocket = serverSocket.accept();
                // TODO Will indexof int in list of Integers work?
                int remotePort = helperSocket.getPort();
                int connectedHelperID = Common.portMap.indexOf(remotePort);
                // TODO Does this really work?
                if (connectedHelperID == -1) {
                    helperSockets.add(helperSocket);
                    System.out.println("Helper " + id + " added socket from incoming: local port: " + helperSocket.getLocalPort() + " remote port: " + helperSocket.getPort());
                }
            }
        } catch (IOException e) {
            // TODO Auto-generated catch block
            e.printStackTrace();
        }
    }
}

Upvotes: 1

Views: 1442

Answers (3)

Rooster
Rooster

Reputation: 1277

Not a true solution, but I ended up working around setting the local port (because nobody seems to like that idea).

Upvotes: 0

void_ptr
void_ptr

Reputation: 472

Can you make a simple test-case and post the source? That'll help us troubleshoot this better.

new Socket("localhost", 1111, InetAddress.getLocalHost(), localPort);

What exactly are you trying to do here? Why do you need to define what local host/port pair to use locally? A client should normally just specify the remote host/port and let the OS pick the local port. This is perhaps the problem.

Upvotes: 1

Eric Rosenberg
Eric Rosenberg

Reputation: 1533

This is a WAG, but I'd try the other constructors in Socket.

Try new Socket(INetAddress.getLocalHost(), "111");

See:

http://ashishmyles.com/tutorials/tcpchat/index.html

Upvotes: 1

Related Questions