CODEWITHSUNDEEP
sql-serverdatabase
Swinders
Swinders

Reputation: 2281

Editing database records by multiple users

I have designed database tables (normalised, on an MS SQL server) and created a standalone windows front end for an application that will be used by a handful of users to add and edit information. We will add a web interface to allow searching accross our production area at a later date.

I am concerned that if two users start editing the same record then the last to commit the update would be the 'winner' and important information may be lost. A number of solutions come to mind but I'm not sure if I am going to create a bigger headache.

  1. Do nothing and hope that two users are never going to be editing the same record at the same time. - Might never happed but what if it does?
  2. Editing routine could store a copy of the original data as well as the updates and then compare when the user has finished editing. If they differ show user and comfirm update - Would require two copies of data to be stored.
  3. Add last updated DATETIME column and check it matches when we update, if not then show differences. - requires new column in each of the relevant tables.
  4. Create an editing table that registers when users start editing a record that will be checked and prevent other users from editing same record. - would require carful thought of program flow to prevent deadlocks and records becoming locked if a user crashes out of the program.

Are there any better solutions or should I go for one of these?

Upvotes: 34

Views: 29241

Answers (8)

Guy
Guy

Reputation: 9816

Another option is to test that the values in the record that you are changing are the still the same as they were when you started: 

SELECT 
    customer_nm,
    customer_nm AS customer_nm_orig
FROM demo_customer
WHERE customer_id = @p_customer_id

(display the customer_nm field and the user changes it)

UPDATE demo_customer
SET customer_nm = @p_customer_name_new
WHERE customer_id = @p_customer_id
AND customer_name = @p_customer_nm_old

IF @@ROWCOUNT = 0
    RAISERROR( 'Update failed: Data changed' );

You don't have to add a new column to your table (and keep it up to date), but you do have to create more verbose SQL statements and pass new and old fields to the stored procedure.

It also has the advantage that you are not locking the records - because we all know that records will end up staying locked when they should not be...

Upvotes: 1

mohamed elbagory
mohamed elbagory

Reputation: 21

-first create filed (update time) to store last update record -when any user select record save select time, compare between select time and update time field if( update time) > (select time) that mean another user update this record after select record

Upvotes: 2

karlgrz
karlgrz

Reputation: 14741

@ Mark Harrison : SQL Server does not support that syntax (SELECT ... FOR UPDATE).

The SQL Server equivalent is the SELECT statement hint UPDLOCK.

See SQL Server Books Online for more information.

Upvotes: 2

Dave Ward
Dave Ward

Reputation: 60580

If you expect infrequent collisions, Optimistic Concurrency is probably your best bet.

Scott Mitchell wrote a comprehensive tutorial on implementing that pattern:
Implementing Optimistic Concurrency

Upvotes: 15

Linh danh thue
Linh danh thue

Reputation: 11

With me, the best way i have a column lastupdate (timetamp datatype). when select and update just compare this value another advance of this solution is that you can use this column to track down the time data has change. I think it is not good if you just create a colum like isLock for check update.

Upvotes: 0

AJ.
AJ.

Reputation: 13761

A classic approach is as follows:

  • add a boolean field , "locked" to each table.
  • set this to false by default.

  • when a user starts editing, you do this:

    • lock the row (or the whole table if you can't lock the row)
    • check the flag on the row you want to edit
    • if the flag is true then
      • inform the user that they cannot edit that row at the moment
    • else
      • set the flag to true

    • release the lock

    • when saving the record, set the flag back to false

Upvotes: 4

Ian W
Ian W

Reputation:

SELECT FOR UPDATE and equivalents are good providing you hold the lock for a microscopic amount of time, but for a macroscopic amount (e.g. the user has the data loaded and hasn't pressed 'save' you should use optimistic concurrency as above. (Which I always think is misnamed - it's more pessimistic than 'last writer wins', which is usually the only other alternative considered.)

Upvotes: 1

Mark Harrison
Mark Harrison

Reputation: 304434

The database will do this for you. Look at "select ... for update", which is designed just for this kind of thing. It will give you a write lock on the selected rows, which you can then commit or roll back.

Upvotes: 0

Related Questions