CODEWITHSUNDEEP
javascriptjqueryfirefoxgoogle-chrome
Octavian
Octavian

Reputation: 4589

Simple jQuery script works fine in Chrome and it fails in Firefox

I have this code:

    <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>The management panel</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

<script type='text/javascript' src='http://code.jquery.com/jquery-1.7.1.min.js'></script>
<script type="text/javascript">
function markPercentages(){
    var checked = $(':checked');
    var percentage = Math.round((1 / checked.length) * 100);
    checked.siblings('.percentage').html(percentage);
    $('input[type=checkbox]').not(checked).siblings('.percentage').html('0');
}
</script>

</head>
<body>
    <form>
    Building<br /><div><input type="checkbox" onclick='markPercentages()' name="6" value="6"> Susilo 2A-13 (<span class='percentage'>0</span>%)</div><br />
    <div><input type="checkbox" onclick='markPercentages()' name="7" value="7"> Susilo 2A-12 (<span class='percentage'>0</span>%)</div>


    <br />Category<br /><select name="title"><option value="Wages">Wages</option><option value="Listrik">Listrik</option><option value="Iuran Bulanan">Iuran Bulanan</option></select><br />
        On<br /><input type=text name=date id=date /><br />

    Notes<br /><input type=text name=note /><br />
    Value<br /><input type=text name=cost onChange="addDecimalPoints(this.id)" id=cost /><br />
    <input type=submit value="Save" />
    </form>

</body>
</html>

It shows a percentage right next to the building (Susilos) of the cost that it's adding. In simplest terms, if one is checked it shows 100%, if two are checked it shows 50% on the first and 50% on the second and so on.

It works fine in Chrome but in Firefox when I check just one, it shows 50% on that, like there are checked two. When I check two it shows 33% on those, like I checked three of them. Why this happen and how I should fix this?

Anyway , deleting a part of the code that's beyond that code makes that works also:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title>The management panel</title>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />

<script type='text/javascript' src='http://code.jquery.com/jquery-1.7.1.min.js'></script>
<script type="text/javascript">
function markPercentages(){
    var checked = $(':checked');
    var percentage = Math.round((1 / checked.length) * 100);
    checked.siblings('.percentage').html(percentage);
    $('input[type=checkbox]').not(checked).siblings('.percentage').html('0');
}
</script>

</head>
<body>
    <form>
    Building<br /><div><input type="checkbox" onclick='markPercentages()' name="6" value="6"> Susilo 2A-13 (<span class='percentage'>0</span>%)</div><br />
    <div><input type="checkbox" onclick='markPercentages()' name="7" value="7"> Susilo 2A-12 (<span class='percentage'>0</span>%)</div>

    </form>

</body>
</html>

Thanks

Upvotes: 1

Views: 348

Answers (3)

themerlinproject
themerlinproject

Reputation: 3582

http://jsfiddle.net/sjRAu/ - working all browsers

HTML:

<div>
    <input type='checkbox' />Susilo 2A-13 (<span class='percentage'>0</span>%)
</div>
<div>
    <input type='checkbox' />Susilo 2A-14 (<span class='percentage'>0</span>%)
</div>
<div>
    <input type='checkbox' />Susilo 2A-15 (<span class='percentage'>0</span>%)
</div>

JS:

$(document).ready(function() {
$('input').click(function(){
    markPercentages();  
});

function markPercentages(){
    var checked = $(':checked');
    var percentage = Math.round((1 / checked.length) * 100);
    checked.siblings('.percentage').html(percentage);
    $('input[type=checkbox]').not(checked).siblings('.percentage').html('0');
}

});

If you have more inputs on the page just give your checkboxes a class like 'markbox' and change 'input' to '.markbox' in your JS

Upvotes: 1

Blender
Blender

Reputation: 298532

Try this code. I basically rewrote all of your logic:

<html>
<head>
<script type='text/javascript' src='http://code.jquery.com/jquery-1.7.1.min.js'></script>
<script type="text/javascript">
$(document).ready(function() {
    $(':checkbox').change(function() {
        var num_checked = $(':checkbox:checked').length;

        if (num_checked == 0) {
            $(':checkbox').each(function() {
                $(this).siblings('.percentage:eq(0)').text('0');
            });

            return;
        }

        var percentage = Math.round(100 / num_checked);

        $(':checkbox').each(function() {
            if ($(this).is(':checked')) {
                $(this).siblings('.percentage:eq(0)').text(percentage);
            } else {
                $(this).siblings('.percentage:eq(0)').text('0');
            }
        });
    });
});
</script>
</head>
<body>
<div>
    <input type='checkbox'/>Susilo 2A-13 (<span class='percentage'>0</span>%)
</div>
<div>
    <input type='checkbox' />Susilo 2A-14 (<span class='percentage'>0</span>%)
</div>
<div>
    <input type='checkbox' />Susilo 2A-15 (<span class='percentage'>0</span>%)
</div>
</body>
</html>

Demo: http://jsfiddle.net/NKuHS/3/

Upvotes: 1

Khairu Aqsara
Khairu Aqsara

Reputation: 1310

what about use like this one

$(function(){
   $('input[type=checkbox').click(function(){
          var checked = $('input[type=checkbox]').attr('checked');
          var percentage = Math.round((1 / checked.length) * 100);
          checked.siblings('.percentage').html(percentage);
          $('input[type=checkbox]').not(checked).siblings('.percentage').html('0');         
   });
});

Upvotes: 1

Related Questions