CODEWITHSUNDEEP
c#visual-studiodebuggingresharpernullreferenceexception
Justin Morgan
Justin Morgan

Reputation: 30690

Can Visual Studio tell me which reference threw a NullReferenceException?

I'm writing unit tests for an MVC web app, and I've been getting null reference exceptions because the mocked-up test objects are only partly initialized. I know which line is throwing the exceptions, and it looks something like this:

return Supervisor.RegistrationInformation.Registrations
    .Any(r =>
        r.RegistrationCountry.IsUSAOrCandada() &&
        (!DatesWorked.Start.HasValue || r.RegistrationDate <= DatesWorked.Start.Value) &&
        (!DatesWorked.End.HasValue || r.RegistrationExpirationDate >= DatesWorked.End.Value) &&
        //...

There are a lot of references in there, and any of them could be the problem. However, NullReferenceException itself doesn't seem to capture which reference blew up. The fact that I'm passing in a lambda presents another challenge: As far as I can tell, I can't step through the lambda during debugging and see which members of r are null.

Is there any way I can do one or both of the following:

I feel like there must be a way to do these things, but I can't seem to find it. I'm on VS2010 Premium, and I have Resharper, VS Power Tools, and a couple other extensions installed. If there's an add-on that does this, I'd be fine with that.

Edit:

As Eric Lippert points out, it's impossible to pinpoint the source of an NR exception when the code has been compiled in Release configuration. I'm only asking about working in debug mode. If Visual Studio (or some extension to VS) can track the source of a reference while debugging, that would answer my question.

Edit 2:

The second question--how to break and step through a lambda--has been answered, but I'd still like to know if there's an automatic way to track down a null reference.

Upvotes: 10

Views: 4081

Answers (8)

user3483639
user3483639

Reputation: 225

yes.You need to install the Resharper extension in visual studio. Resharper is Continuous code quality analysis tool.

you can find more details on below link

https://www.jetbrains.com/resharper/

Upvotes: 0

Joe White
Joe White

Reputation: 97768

This won't solve your entire problem, but it should help:

You can set a breakpoint inside the lambda -- just not in the usual way (clicking in the gutter will breakpoint the containing statement, not the innards of the lambda). You have to put the cursor inside the lambda and hit F9 -- then you'll get a breakpoint inside your lambda.

Upvotes: 3

Jason Williams
Jason Williams

Reputation: 57922

The immediate problem is that the lambda is wrapping a lot of complex logic up in a single statement, so you can't find where the crash happened.

But that's just a side effect. The real problem is that your code is assuming, incorrectly, that none of the references will be null.

One approach would be to try to isloate the crash and put a bandage over the "bit that broke". But that will not attack the root of the problem: there are unchecked assumptions in the code, and you already have proof that at least one of them is wrong. If another one is wrong, then at some undefined point in future, your program will probably crash again, and you will debug and bandage again. This can go on and on, and your code will get hacked about every time.

You need to put down your debugger and think about the code. All of the code, in one pass. "Desk-check" it: run through each part of the expression and ask yourself "Can this bit be null? What will happen if it is? And if so, how can I make it safe?"

That way, you will be able to re-write the entire expression in a form that you know is null-aware, and you won't ever need to debug into it to work out why it blew up.

For example, this:

    r.RegistrationCountry.IsUSAOrCandada() &&

...could cause a null dereference if r==null or if r.RegistrationCountry==null. The code needs to check for these possibilities. The "most defensive" code would be to check every reference something like this:

    r != null && r.RegistrationCountry != null && r.RegistrationCountry.IsUSAOrCandada() &&

which guarantees that each step will only be executed if the previous step succeeded. Note though, that the list may never provide r==null, so that check might not be necessary. Or r.RegistrationCountry may be a struct (a non-nullable type), so you'll know that check is unrequired. So you can avoid unnecessary checks by thinking about it. But you need to think through each part of the code to challenge and eliminate all the assumptions.

Upvotes: 1

mqp
mqp

Reputation: 71985

I wouldn't normally make a non-answer answer, but I think that the answer saying there is no general way to do this is not correct.

It seems to me like you could write a wrapper function taking an expression tree, decomposing each subexpression that has property and field accessors, and reconstructing it with explicit null checks that throw an informative exception on each of those accessors. Pseudocode:

static Expression<Func<T, bool>> WithNullDebugging(Expression<Func<T, bool>> exp)
{
    for each node in the expression tree
        if node is a field, property, or method accessor
            generate a null check for this member and an exception throw
            substitute the checked node for this node
        else if the node has subexpression children
            call this method recursively on each child
            substitute each checked subexpression for the subexpression

    return the fixed expression tree
}

I don't usually do metaprogramming in C#, so I'm not sure, but I think this is quite possible; someone smart let me know if it's not, and I'll remove or fix this answer.

Upvotes: 1

Omer Raviv
Omer Raviv

Reputation: 11827

You can put a breakpoint inside the lambda expression, and when it hits, you should be able to hover over the expression and see their values just fine.

Looking at your code, I can see that only one of three expressions might've caused the NullRef- r, r.RegistrationCountry and DatesWorked.

Put those three expressions in your Watch window, and either ask the debugger to break on any NullReferenceException (via Debug->Exceptions), or put a breakpoint inside the lambda expression, and make it a conditional breakpoint on the condition r == null || r.RegistrationCountry == null || DatesWorked == null, and the answer should appear pretty quick.

Upvotes: 1

Coincoin
Coincoin

Reputation: 28606

One solution for your particular problem is to rewrite the lambda in a multiline one that evaluates every condition one by one and returns explicitely. You can then more easily trace through it and find the null reference.

Upvotes: 2

Eric Lippert
Eric Lippert

Reputation: 660279

There is not in general a way to do what you want, no. To understand why, think about what is happening when a null reference exception is thrown. Imagine that you are the compiler, and you must emit code to process a call to abc.Def.Ghi.Jkl(), where abc is a local, Def and Ghi are fields of reference type, and Jkl is a method. There is no IL instruction that can do something that complicated; you have to break it down. So you emit code for an equivalent program where everything is much simpler. You emit the program fragment:

temp1 = abc.Def;
temp2 = temp1.Ghi;
temp2.Jkl();

Suppose temp2 is null because Ghi was null. That fact will not be discovered until Jkl is invoked, at which point the thing throwing the exception does not have any knowledge of how temp2 was initialized. That happened long ago, a nanosecond in the past and machine code has no memory of the past; the null reference does not keep a little note on it that says where the null came from, any more than when you say "a = b + c", the resulting number twelve does not keep a note along with it that says "I was the sum of b and c".

Upvotes: 16

i_am_jorf
i_am_jorf

Reputation: 54600

If you set a breakpoint here, you should be able to inspect each of the values before the line is executed and the exception is thrown. You just have to methodically look at each dereferenced item until you find the Null one. Visual Studio is very good at this sort of thing.

Upvotes: 1

Related Questions