CODEWITHSUNDEEP
c#linqdatacontextsubmitchanges
Johnny
Johnny

Reputation: 425

LinQ DataContext - The operation cannot be performed during a call to SubmitChanges

The code which is throwing exception is extremely easy - this is very regular insert and then submit changes statement which looks:

context.tb_dayErrorLog.InsertOnSubmit(data);
context.SubmitChanges();

So really nothing special. This statement is executed about 50 thousands times a day without any problem, but: about 6 - 10 times a day it finishes with:

The operation cannot be performed during a call to SubmitChanges.

StackTrace:    at System.Data.Linq.DataContext.CheckNotInSubmitChanges()
at System.Data.Linq.Table`1.InsertOnSubmit(TEntity entity)

I was trying to find out what that can be but can't find a clue This behavior is very not deterministic politely saying - how it can finish 50k times correctly and few times not?

DataContext was firstly initialized as a static one, and then reused for all the calls, so I was thinking maybe that's the problem. Then I changed it to be initialized with every call but results are quite similar. Still few exceptions a day.

Any idea?

some additions: function looks like:

public override bool Log(ErrorLogData logData)
    {

        try
        {
            logData.ProcessID = _processID;
            //Create new log dataset
            var data = new DataRecord
            {
                application = logData.Application,
                date = DateTime.Now,
                Other = logData.Other,
                process = logData.ProcessName,
                processid = logData.ProcessID,
                severity = logData.Severity,
                username = logData.UserName,
                Type = (short)logData.ErrorType
            };


            var context = new DataContext(ConnectionString);

            context.tb_dayErrorLog.InsertOnSubmit(data);
            context.SubmitChanges();

        }
        catch (Exception ex)
        {
            //log log in eventviewer
            LogEvent(logData.ToString(), ex);
            return false;
        }
        return true;
    }

so simple record initialization and then insert.

As I wrote in the comment, while making same thing by Ado.Net and SqlCommand this problem is not occuring...

So my curiosity makes me think why?

Upvotes: 4

Views: 4328

Answers (2)

MiguelSlv
MiguelSlv

Reputation: 15193

@SgMoore points to concurrency problem and in my case it really was. If that's the case another approach is to use lock like this:

 String lockValue = "";

  lock (lockValue)
  {
       context.tb_dayErrorLog.InsertOnSubmit(data);//UPDATE: concurrency error can  occur here too
       context.dc.SubmitChanges(); 
  }

Upvotes: 0

sgmoore
sgmoore

Reputation: 16077

This sounds like a threading issue where you are calling Log and hence SubmitChanges on one thread when another thread is in the middle of SubmitChanges.

I suspect your DataContext is still a global static variable.

Try changing your Log method to 

using (var context = new DataContext(ConnectionString))
{
    context.tb_dayErrorLog.InsertOnSubmit(data);
    context.SubmitChanges();
}

Upvotes: 5

Related Questions