omnia Mm
omnia Mm

Reputation: 157

Parse error: syntax error, unexpected T_IF

$query = "SELECT a.*, cc.name AS category, dd.ezcity AS proploc, ee.name AS statename, ff.name AS cnname, ss.dealer_name AS propseller, u.name AS editor"

. "\n FROM #__ezrealty AS a"

. "\n LEFT JOIN #__ezrealty_catg AS cc ON cc.id = a.cid"

. "\n LEFT JOIN #__ezrealty_locality AS dd ON dd.id = a.locid"

. "\n LEFT JOIN #__ezrealty_state AS ee ON ee.id = a.stid"

. "\n LEFT JOIN #__ezrealty_country AS ff ON ff.id = a.cnid"

. "\n LEFT JOIN #__ezrealty_profile AS ss ON ss.mid = a.owner"

. "\n LEFT JOIN #__users AS u ON u.id = a.checked_out"

. ( count( $where ) ? "\n WHERE " . implode( ' AND ', $where ) : "")

. if ( isset ($_POST['idSearch']) ) 

    . { " WHERE a.id = " . $_POST['idSearch']  ; }

. "\n ORDER BY ". $order

. "\n LIMIT $pageNav->limitstart, $pageNav->limit"

;

i don get the wrong syntax here :( ,, and it keep return the same error unexpected T_IF

Upvotes: 1

Views: 7097

Answers (4)

lonesomeday
lonesomeday

Reputation: 237975

if can only ever be a statement: you are using it as an expression. It doesn't return anything, and it cannot be used within another statement.

You can, however, use the ternary operator to do exactly this:

. ( isset ($_POST['idSearch']) ?  " WHERE a.id = " . $_POST['idSearch'] : '') 

This says "if $_POST['idSearch'] is set, add that string, otherwise, add the empty string.

Note that you should really look at your code, because there is a glaring SQL injection in just the code that I've posted above. Anyone could execute arbitrary code on your database. Make sure to sanitise your input and, preferably, adopt prepared statements and parameterised queries to make your code more secure.

Upvotes: 1

Explosion Pills
Explosion Pills

Reputation: 191779

I believe you want to turn this into an evil ternary operator:

. (count ...)
. (isset($_POST['idSearch']) ? ' WHERE a.id = ' . $_POST['idSearch'] : '')
. "\n ORDER BY" ...

Upvotes: 0

Alex Howansky
Alex Howansky

Reputation: 53591

Don't do this:

. if (condition) { value_if_true; }

Instead do this:

. (condition ? value_if_true : value_if_false)

Upvotes: 2

Alex van den Hoogen
Alex van den Hoogen

Reputation: 754

Remove the . (point) before the if-statement. Because the if-statement itself isn't a string you can't just concatenate it.

Upvotes: 3

Related Questions